Re: [PATCH] gnu: agg: New variable.

["Tomáš Čech" <sleep_walker@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]

Thanks for review,

it seems that I'm getting too chaotic as I work on many packages
simultaneously. Sorry about that.


On Tue, Mar 17, 2015 at 10:10:56AM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> * gnu/packages/graphics.scm (agg): New variable.
>
>Please adjust the commit’s subject line as Andreas suggested.

Fixed.

>
>> +              (uri (string-append "http://www.antigrain.com/agg-"
>> +                                  version ".tar.gz"))
>> +              (sha256 (base32
>> +                       "07wii4i824vy9qsvjsgqxppgqmfdxq0xa87i5yk53fijriadq7mb"))
>
>Maybe put ‘base32’ on the next line, as is done in the rest of this file
>an elsewhere.

Fixed.

>
>> +              (patches (list (search-patch "am_c_prototype.patch")
>> +                             (search-patch
>> +                              "antigrain-geometry-no_rpath.patch")))))
>
>Please add these two patches to the patch, and list them in
>gnu-system.am.

This is critical miss.
>
>> +       (alist-cons-after
>> +        'unpack 'autoreconf
>> +        (lambda _
>> +          ;; let's call configure from configure phase and not now
>> +          (substitute* "autogen.sh" (("./configure") "# ./configure"))
>> +          (zero? (system* "sh" "autogen.sh")))
>
>So the tarball they provide is not generated from ‘make dist’?  Bah.

No, really, I'm glad I made it compile.

>> +    (synopsis "A high quality rendering engine for C++")
>
>“High-quality 2D graphics rendering engine for C++”

The best text to be placed there is already taken by authors and wikipedia
people. It's hard to divert :b

Rest fixed as well.

Thanks for the review.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]