From: Marius Bakke <mbakke@fastmail.com>
To: Julien Lepiller <julien@lepiller.eu>, guix-devel@gnu.org
Subject: Re: [PATCH 00/10] ocaml patches
Date: Wed, 18 Jan 2017 23:27:06 +0100 [thread overview]
Message-ID: <87pojk6m2t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170118202802.5073-1-julien@lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Julien Lepiller <julien@lepiller.eu> writes:
> Here are the next 10 ocaml-related patches I would like to push. What do you
> think?
I don't know anything about ocaml, but the patches reads fine to me.
One thing that strikes me is the usage of native-inputs; I assume it's
because the packages are not referenced, but bear in mind that they are
built for the architecture of the build machine, and not for the target
system.
E.g. `guix build --system=i686-linux ocamlify` will add 64-bit
native-inputs even if the final product is supposed to be 32-bit. Not
sure if that will cause problems or not.
> I'm pretty sure number 9 and 10 can be improved, any idea?
Not from me, I'd say it looks fine :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-01-18 22:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 20:27 [PATCH 00/10] ocaml patches Julien Lepiller
2017-01-18 20:27 ` [PATCH 01/10] gnu: Add ocaml-base64 Julien Lepiller
2017-01-18 20:27 ` [PATCH 02/10] gnu: Add ocamlify Julien Lepiller
2017-01-18 20:27 ` [PATCH 03/10] gnu: Add omake Julien Lepiller
2017-01-18 22:00 ` Marius Bakke
2017-01-18 20:27 ` [PATCH 04/10] gnu: Add ocaml-batteries Julien Lepiller
2017-01-18 20:27 ` [PATCH 05/10] gnu: Add ocaml-pcre Julien Lepiller
2017-01-18 20:27 ` [PATCH 06/10] gnu: Add ocaml-expect Julien Lepiller
2017-01-18 20:27 ` [PATCH 07/10] gnu: Add ocaml-fileutils Julien Lepiller
2017-01-18 20:28 ` [PATCH 08/10] gnu: Add ocaml-oasis Julien Lepiller
2017-01-18 22:14 ` Marius Bakke
2017-01-18 20:28 ` [PATCH 09/10] gnu: Add ocaml-js-build-tools Julien Lepiller
2017-01-18 22:21 ` Marius Bakke
2017-01-20 13:28 ` Ludovic Courtès
2017-01-18 20:28 ` [PATCH 10/10] gnu: Add ocaml-bin-prot Julien Lepiller
2017-01-18 22:27 ` Marius Bakke [this message]
2017-01-19 8:56 ` [PATCH 00/10] ocaml patches Julien Lepiller
-- strict thread matches above, loose matches on Subject: below --
2017-01-31 20:58 Julien Lepiller
2017-02-07 20:16 ` Julien Lepiller
2017-02-07 22:24 ` Ben Woodcroft
2017-02-08 11:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pojk6m2t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).