Re: [PATCH 00/10] ocaml patches

[ludo@gnu.org (Ludovic Courtès)]

Hi,

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 08/02/17 06:16, Julien Lepiller wrote:
>> On Tue, 31 Jan 2017 21:58:05 +0100
>> Julien Lepiller <julien@lepiller.eu> wrote:
>>
>>> Here is the next series of patches. I think I took into account all
>>> of your previous remarks, so it should be faster.
>>>
>>> Julien Lepiller (10):
>>>    gnu: Add ocaml-fieldslib.
>>>    gnu: Add ocaml-ppx-core.
>>>    gnu: Add ocaml-ppx-optcomp.
>>>    gnu: Add ocaml-ppx-driver.
>>>    gnu: Add ocaml-cppo.
>>>    gnu: Add ocaml-ppx-deriving.
>>>    gnu: Add ocaml-ppx-type-conv.
>>>    gnu: Add ocaml-ppx-inline-test.
>>>    gnu: Add ocaml-ppx-bench.
>>>    gnu: Add ocaml-ppx-compare.
>>>
>>>   gnu/packages/ocaml.scm | 255
>>> +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 255
>>> insertions(+)
>>>
>> Up?
>>
>> Can I push them?
> I've been meaning to review these patches but haven't found the time..
>
> If they pass 'guix lint' then I would think it is OK to push
> them. Thanks for your efforts on the OCaml front.

I concur, sorry for the delay Julien!

That’s really a minor issue but in the future, please make sure
descriptions contain full sentences and use @code and similar where it
makes sense.

Also, feel free to push simple packages if they pass ‘guix lint’ and you
don’t get feedback within a few days (see ‘HACKING’).

Thanks for working the OCaml front!  :-)

Ludo’.