From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] lint: add 'source' checker.
Date: Mon, 29 Dec 2014 21:32:34 +0100 [thread overview]
Message-ID: <87oaqm19jx.fsf@gnu.org> (raw)
In-Reply-To: <1419824407-6471-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Mon, 29 Dec 2014 04:40:07 +0100")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> +(define (check-source package)
> + ""
> + (let ((origin (package-source package)))
> + (when (and origin
> + (eqv? (origin-method origin) url-fetch))
> + (let* ((strings (origin-uri origin))
> + (uris (if (list? strings)
> + (map string->uri strings)
> + (list (string->uri strings)))))
I realized while fixing it in list-packages.scm that mirror:// URIs
actually need to be expanded here. See commit 1c69e4c for an example.
Ludo’.
next prev parent reply other threads:[~2014-12-29 20:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 17:02 New home-page checker for ‘guix lint’ Ludovic Courtès
2014-12-29 3:08 ` Cyril Roelandt
2014-12-29 3:40 ` [PATCH] lint: add 'source' checker Cyril Roelandt
2014-12-29 13:05 ` David Thompson
2014-12-29 14:23 ` Ludovic Courtès
2015-01-03 2:43 ` Cyril Roelandt
2015-01-03 19:11 ` Ludovic Courtès
2014-12-29 20:32 ` Ludovic Courtès [this message]
2015-01-15 7:52 ` [PATCHv2] " Cyril Roelandt
2015-01-15 21:58 ` Ludovic Courtès
2015-01-23 9:56 ` Ludovic Courtès
2015-01-25 17:43 ` Cyril Roelandt
2014-12-29 14:18 ` New home-page checker for ‘guix lint’ Ludovic Courtès
2014-12-29 20:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaqm19jx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).