From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] lint: add 'source' checker.
Date: Mon, 29 Dec 2014 21:32:34 +0100
Message-ID: <87oaqm19jx.fsf@gnu.org>
References: <54A0C5A8.2030105@gmail.com>
	<1419824407-6471-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42918)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y5gze-0005de-LF
	for guix-devel@gnu.org; Mon, 29 Dec 2014 15:32:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y5gzb-000378-Eo
	for guix-devel@gnu.org; Mon, 29 Dec 2014 15:32:46 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:33444)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y5gzb-00036j-8m
	for guix-devel@gnu.org; Mon, 29 Dec 2014 15:32:43 -0500
In-Reply-To: <1419824407-6471-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Mon, 29 Dec 2014 04:40:07 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> +(define (check-source package)
> +  ""
> +  (let ((origin (package-source package)))
> +    (when (and origin
> +               (eqv? (origin-method origin) url-fetch))
> +      (let* ((strings (origin-uri origin))
> +             (uris (if (list? strings)
> +                       (map string->uri strings)
> +                       (list (string->uri strings)))))

I realized while fixing it in list-packages.scm that mirror:// URIs
actually need to be expanded here.  See commit 1c69e4c for an example.

Ludo=E2=80=99.