From: Cyril Roelandt <tipecaml@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] lint: add 'source' checker.
Date: Sat, 03 Jan 2015 03:43:42 +0100 [thread overview]
Message-ID: <54A7575E.7040903@gmail.com> (raw)
In-Reply-To: <871tni357m.fsf@gnu.org>
On 12/29/2014 03:23 PM, Ludovic Courtès wrote:
> Cyril Roelandt <tipecaml@gmail.com> skribis:
>
>> * guix/scripts/lint.scm (uri-available?): New procedure.
>> (%checkers): Add 'home-page' checker
>
> Some comments in addition to what David already wrote.
>
>> +(define (uri-available? uri)
>> + "Return #t if the given URI can be reached, otherwise throw a
>> +'not-available exception along with an appropriate error message."
>
> By convention, one would expect ‘uri-available?’ to return #t or #f, not
> to throw.
>
> How about calling it ‘validate-uri’ and directly call ‘emit-warning’
> from there? It would need the field name as an additional argument.
>
This would also require passing the "package" to validate-uri. How about
we make uri-available? return #t/#f, and just don't really care about
the exact reason why it failed ? Anyway a human being is going to
manually check what happened to know whether this is a real issue or
just a server that went down for a couple hours, or a file that wrongly
got removed...
Cyril.
next prev parent reply other threads:[~2015-01-03 2:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 17:02 New home-page checker for ‘guix lint’ Ludovic Courtès
2014-12-29 3:08 ` Cyril Roelandt
2014-12-29 3:40 ` [PATCH] lint: add 'source' checker Cyril Roelandt
2014-12-29 13:05 ` David Thompson
2014-12-29 14:23 ` Ludovic Courtès
2015-01-03 2:43 ` Cyril Roelandt [this message]
2015-01-03 19:11 ` Ludovic Courtès
2014-12-29 20:32 ` Ludovic Courtès
2015-01-15 7:52 ` [PATCHv2] " Cyril Roelandt
2015-01-15 21:58 ` Ludovic Courtès
2015-01-23 9:56 ` Ludovic Courtès
2015-01-25 17:43 ` Cyril Roelandt
2014-12-29 14:18 ` New home-page checker for ‘guix lint’ Ludovic Courtès
2014-12-29 20:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A7575E.7040903@gmail.com \
--to=tipecaml@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).