Fwd: Re: Patch file for colorize module

[Ricardo Wurmus <rekado@elephly.net>]

Hi Sahithi,

a couple of days ago I wrote this:

> We’re still lacking code to actually use “colorize-string” anywhere.
> Could you please prepare a patch or a series of patches that achieves
> the following:
>
> * add a soft port to (guix ui) that colorizes strings that match an
>   internal list of regular expressions.  The initial list of regular
>   expressions could be something like this:
>
>   '("^starting phase.*"
>     "^phase .* succeeded.*"
>     "^phase .* failed.*")
>
>   See the documentation for “string-match” for details.
>
>   Initially, the port should print any matching string as just green.
>   All other strings should not be modified at all.  This will become a
>   little fancier in the future to allow use to apply different colours
>   or formatting to different parts of the strings just like it is done
>   by “guix-build-log-minor-mode” of the Emacs interface for Guix.  (If
>   you haven’t played with that interface yet, please do so.)
>
> * change “guix-package” in “guix/scripts/package.scm” such that it will
>   use the new soft port.  Note that “current-build-output-port” in (guix
>   store) is a so-called parameter, which can be modified dynamically
>   using “parameterize”.  Take a look at “guix/scripts/build.scm” where
>   “current-build-output-port” is parameterized to the void port when
>   “--quiet” was passed (this causes “guix build” to print no build log).
>   The change to “guix-package” should be very similar.
>
> Does this sound like a good idea to you?
>
> By using a soft port I think we can limit future work (e.g. hiding of
> parts of the build output) to just the inner procedures and data
> structures of the soft port.
>
> Please try to give us short updates every two days or so; this way we
> can ensure that any questions you may have can be addressed quickly.
> Please also ask right away when anything is unclear or if the suggested
> approach seems weird.

Have you started on working on this yet?  If so,could you please give us
an update on your progress via email?

-- 
Ricardo