From: Sahitihi <sahi@swecha.net>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: Status of Submitted Patches
Date: Thu, 24 May 2018 22:46:19 +0530 [thread overview]
Message-ID: <3a887aae-93f5-7e70-c8af-9bf4b4d17cb4@swecha.net> (raw)
In-Reply-To: <87d0xmok8e.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi Ricardo,
> Another note about style: I think it would be better to use
> “alist->hash-table” instead of “make-hash-table” followed by repeated
> modifications to the hash table with “hashq-set!”. We prefer to avoid
> mutation of values when possible.
I have made all necessary modifications. Can please review it once.
> Regarding copyright headers: please make sure to also add a copyright
> line for yourself and a copyright line from the file of guile-colorize
> to “(guix ui)”.
>
> When you’re done with these changes, please make a local commit and send
> the output of “git format-patch -1”.
I will proceed further once it is reviewed. :)
Thanks!!
---
Sahithi
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: term ansi-color.scm --]
[-- Type: text/x-scheme; name="term ansi-color.scm", Size: 1552 bytes --]
(define-module (term ansi-color)
#:export (color
colorize-string)
#:use-module (srfi srfi-1) ; for 'remove'
#:use-module (srfi srfi-13)) ; for 'string-join'
(define ansi-color-tables
`((CLEAR . "0")
(RESET . "0")
(BOLD . "1")
(DARK . "2")
(UNDERLINE . "4")
(UNDERSCORE . "4")
(BLINK . "5")
(REVERSE . "6")
(CONCEALED . "8")
(BLACK . "30")
(RED . "31")
(GREEN . "32")
(YELLOW . "33")
(BLUE . "34")
(MAGENTA . "35")
(CYAN . "36")
(WHITE . "37")
(ON-BLACK . "40")
(ON-RED . "41")
(ON-GREEN . "42")
(ON-YELLOW . "43")
(ON-BLUE . "44")
(ON-MAGENTA . "45")
(ON-CYAN . "46")
(ON-WHITE . "47")))
(define (color . lst)
(let ((color-list
(remove not
(map (lambda (color) (assq-ref ansi-color-tables color))
lst))))
(if (null? color-list)
""
(string-append
(string #\esc #\[)
(string-join color-list ";" 'infix)
"m"))))
(define (colorize-string str . color-list)
(string-append
(apply color color-list)
str
(color 'RESET)))
(display (colorize-string "Hello!\n" 'RED 'BOLD 'ON-BLUE))
(for-each display
(list (color 'RED 'BOLD 'ON-BLUE)
"Hello!"
(color 'RESET)))
next prev parent reply other threads:[~2018-05-24 17:17 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net>
[not found] ` <871sfxev9w.fsf@elephly.net>
[not found] ` <7626275c-3eee-bb05-ab9d-4c88ec6f0329@swecha.net>
[not found] ` <87r2nvjte6.fsf@elephly.net>
[not found] ` <5ab51417-b635-9725-9f48-3bc3f9b61fdf@swecha.net>
[not found] ` <87tvsko2wd.fsf@elephly.net>
[not found] ` <7290013c-990d-3f7d-d8db-38e090ed766a@swecha.net>
[not found] ` <87zi28kt82.fsf@elephly.net>
[not found] ` <8573e97d-d107-cde6-cd17-35f4ef6d2de3@swecha.net>
[not found] ` <87k1takumm.fsf@elephly.net>
[not found] ` <87o9hycwl6.fsf@elephly.net>
2018-05-11 21:16 ` Status of Submitted Patches Sahithi Yarlagadda
2018-05-11 22:21 ` Ricardo Wurmus
2018-05-12 7:50 ` Ricardo Wurmus
2018-05-15 17:41 ` Sahitihi
2018-05-20 9:40 ` Ricardo Wurmus
2018-05-20 10:47 ` Gábor Boskovits
2018-05-20 13:46 ` Ricardo Wurmus
2018-05-23 7:53 ` Sahitihi
2018-05-23 8:21 ` Ricardo Wurmus
2018-05-24 17:16 ` Sahitihi [this message]
2018-05-24 20:00 ` Ricardo Wurmus
2018-05-25 3:43 ` Sahitihi
2018-05-25 5:18 ` Ricardo Wurmus
2018-05-25 17:59 ` Patch file for colorize module Sahitihi
2018-05-26 6:06 ` Sahitihi
2018-05-26 9:35 ` Ricardo Wurmus
2018-05-26 12:06 ` Sahitihi
2018-05-26 14:16 ` Ricardo Wurmus
2018-05-26 18:22 ` Sahitihi
2018-05-26 18:38 ` Sahitihi
2018-05-26 21:20 ` Ricardo Wurmus
2018-05-27 15:49 ` Gábor Boskovits
2018-05-31 6:26 ` Fwd: " Ricardo Wurmus
2018-05-31 18:25 ` Sahitihi
2018-05-31 19:28 ` Ricardo Wurmus
2018-06-02 15:01 ` Ricardo Wurmus
2018-06-03 14:18 ` Sahitihi
2018-06-03 19:30 ` Ricardo Wurmus
2018-06-04 7:48 ` Sahitihi
2018-06-04 10:03 ` Ricardo Wurmus
2018-06-04 18:51 ` Sahitihi
2018-06-05 19:44 ` Ricardo Wurmus
2018-06-06 19:49 ` Sahitihi
2018-06-06 20:06 ` Ricardo Wurmus
2018-06-06 21:20 ` Sahitihi
2018-06-06 21:28 ` Ricardo Wurmus
2018-06-07 3:29 ` Sahitihi
2018-06-07 5:22 ` Ricardo Wurmus
2018-06-07 7:47 ` Sahitihi
2018-06-07 8:25 ` Ricardo Wurmus
2018-06-08 17:01 ` Sahitihi
2018-06-09 0:57 ` Ricardo Wurmus
2018-06-09 18:08 ` Sahitihi
2018-06-09 20:57 ` Ricardo Wurmus
2018-06-11 12:14 ` Sahitihi
2018-06-11 12:28 ` Gábor Boskovits
2018-06-11 16:21 ` Sahitihi
2018-06-12 14:12 ` Ricardo Wurmus
2018-06-12 21:06 ` Sahitihi
2018-06-12 22:12 ` Ricardo Wurmus
2018-06-13 16:08 ` Sahithi Yarlagadda
2018-06-13 19:15 ` Ricardo Wurmus
2018-06-15 20:16 ` Sahitihi
2018-06-15 21:47 ` Next steps Ricardo Wurmus
2018-06-16 14:55 ` Sahitihi
2018-06-21 11:05 ` Ricardo Wurmus
2018-06-21 16:54 ` Sahithi Yarlagadda
2018-06-25 20:13 ` Sahithi Yarlagadda
2018-06-25 20:28 ` Ricardo Wurmus
2018-06-26 20:01 ` Gábor Boskovits
2018-06-29 22:51 ` Sahithi Yarlagadda
2018-07-03 2:29 ` Sahithi Yarlagadda
2018-06-24 18:25 ` Sahithi Yarlagadda
2018-06-24 20:22 ` Ricardo Wurmus
2018-06-24 20:33 ` Sahithi Yarlagadda
2018-06-11 12:37 ` Fwd: Re: Patch file for colorize module Ricardo Wurmus
2018-06-11 16:31 ` Sahitihi
2018-06-04 11:41 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a887aae-93f5-7e70-c8af-9bf4b4d17cb4@swecha.net \
--to=sahi@swecha.net \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).