From: Ricardo Wurmus <rekado@elephly.net>
To: Sahitihi <sahi@swecha.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Fwd: Re: Patch file for colorize module
Date: Sat, 02 Jun 2018 17:01:35 +0200 [thread overview]
Message-ID: <87a7sdb5bk.fsf@elephly.net> (raw)
In-Reply-To: <877enjpquf.fsf@elephly.net>
Hi Sahithi,
do you have any questions about the next steps outlined in the email
below?
Cheers,
Ricardo
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi Sahithi,
>
>>> Have you started on working on this yet? If so,could you please give us
>>> an update on your progress via email?
>>>
>> I have started out using different functions like
>>
>> |1) regexp-match 2) ||string-contains which resulted same output for
>> strings
>
> The procedures tell you if something matched.
>
>> then i tried 1)
>> string-match 2) string-substitute ended up using string substitute so
>> that the result can be colored one.
>
> “string-match” either returns #f if the expression didn’t match or it
> returns a match structure that tells you *how* the expression was
> matched. It is especially useful with match groups that are marked with
> parentheses in the regular expression. See below for an example.
>
>> But I failed executing it. File is
>> attached, Can u suggest where I went wrong.
>
> One obvious failing is in the arguments to “make-soft-port”. It takes a
> vector of five procedures, but you gave it a vector of one procedure
> followed by an expression beginning with “regexp-substitute/global” and
> then three more procedures.
>
> You need to give it five procedures wrapped in a vector.
>
> How about doing it this way:
>
> --8<---------------cut here---------------start------------->8---
> ;; The port to which we write our potentially colorized strings
> (define target-port (current-output-port))
>
> (define (handle-string str)
> "Match on the input string STR and return a new string with added
> color sequences."
> ;; TODO: match on str and pass the modified string to the output port
> (display str target-port))
>
> (define my-colorful-port
> (make-soft-port
> (vector
> (lambda (c) (write c target-port))
> handle-string
> (lambda () (display "." target-port))
> (lambda () (char-upcase (read-char)))
> (lambda () (display "@" target-port)))
> "rw"))
>
> ;;;; Some tests!
>
> (display "Hello there!" my-colorful-port) ; no colours
> (display "starting phase “Big gorilla” — watch out!" my-colorful-port)
> (display "phase “Big gorilla” failed" my-colorful-port)
> (display "I heard phase “Big gorilla” failed" my-colorful-port) ; no colours here
> ;;; …and so on…
> --8<---------------cut here---------------end--------------->8---
>
> Now all you need to do is work on the “handle-string” procedure.
>
> I suggest using simpler matching procedures at first. To get started
> try “string-prefix?” and use it with the string “starting phase”. This
> won’t work with regular expressions, though.
>
> While you *can* use “regexp-substitute/global”, I don’t think it’s a
> good fit here, because we may want to extend the string matching
> features, which is difficult to do with “regexp-substitute/global”.
> Instead, try to match regular expressions one by one with “string-match”
> and then operate on the match structure it returns. If it returns #f
> you can move on to the next expression. If none match you just return
> the original string. If one matches you *rebuild* the string, but with
> colours applied.
>
> Here’s an example:
>
> (define str "My name is Al Jarreau and I’m 76 years old.")
> (define expr "(My name is )(.*)( and I’m )(.*)( years old.)")
>
> These are five match groups and we want to modify the second and fourth,
> so we can do this:
>
> (or (and=> (string-match expr str)
> (lambda (m)
> (string-append
> (match:substring m 1)
> (string-upcase (match:substring m 2))
> (match:substring m 3)
> (string-reverse (match:substring m 4))
> (match:substring m 5))))
> ;; Didn’t match, so return unmodified string.
> str)
>
> If you don’t understand this example please look up the procedures in
> the Guile manual.
>
>> As per IRC discussion with Ricardo, I tried installing emacs and
>> running a shell.
>
> That is correct. We were trying to take a look at the features
> guix-build-log-minor-mode provides, but we didn’t get that far.
--
Ricardo
next prev parent reply other threads:[~2018-06-02 15:02 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net>
[not found] ` <871sfxev9w.fsf@elephly.net>
[not found] ` <7626275c-3eee-bb05-ab9d-4c88ec6f0329@swecha.net>
[not found] ` <87r2nvjte6.fsf@elephly.net>
[not found] ` <5ab51417-b635-9725-9f48-3bc3f9b61fdf@swecha.net>
[not found] ` <87tvsko2wd.fsf@elephly.net>
[not found] ` <7290013c-990d-3f7d-d8db-38e090ed766a@swecha.net>
[not found] ` <87zi28kt82.fsf@elephly.net>
[not found] ` <8573e97d-d107-cde6-cd17-35f4ef6d2de3@swecha.net>
[not found] ` <87k1takumm.fsf@elephly.net>
[not found] ` <87o9hycwl6.fsf@elephly.net>
2018-05-11 21:16 ` Status of Submitted Patches Sahithi Yarlagadda
2018-05-11 22:21 ` Ricardo Wurmus
2018-05-12 7:50 ` Ricardo Wurmus
2018-05-15 17:41 ` Sahitihi
2018-05-20 9:40 ` Ricardo Wurmus
2018-05-20 10:47 ` Gábor Boskovits
2018-05-20 13:46 ` Ricardo Wurmus
2018-05-23 7:53 ` Sahitihi
2018-05-23 8:21 ` Ricardo Wurmus
2018-05-24 17:16 ` Sahitihi
2018-05-24 20:00 ` Ricardo Wurmus
2018-05-25 3:43 ` Sahitihi
2018-05-25 5:18 ` Ricardo Wurmus
2018-05-25 17:59 ` Patch file for colorize module Sahitihi
2018-05-26 6:06 ` Sahitihi
2018-05-26 9:35 ` Ricardo Wurmus
2018-05-26 12:06 ` Sahitihi
2018-05-26 14:16 ` Ricardo Wurmus
2018-05-26 18:22 ` Sahitihi
2018-05-26 18:38 ` Sahitihi
2018-05-26 21:20 ` Ricardo Wurmus
2018-05-27 15:49 ` Gábor Boskovits
2018-05-31 6:26 ` Fwd: " Ricardo Wurmus
2018-05-31 18:25 ` Sahitihi
2018-05-31 19:28 ` Ricardo Wurmus
2018-06-02 15:01 ` Ricardo Wurmus [this message]
2018-06-03 14:18 ` Sahitihi
2018-06-03 19:30 ` Ricardo Wurmus
2018-06-04 7:48 ` Sahitihi
2018-06-04 10:03 ` Ricardo Wurmus
2018-06-04 18:51 ` Sahitihi
2018-06-05 19:44 ` Ricardo Wurmus
2018-06-06 19:49 ` Sahitihi
2018-06-06 20:06 ` Ricardo Wurmus
2018-06-06 21:20 ` Sahitihi
2018-06-06 21:28 ` Ricardo Wurmus
2018-06-07 3:29 ` Sahitihi
2018-06-07 5:22 ` Ricardo Wurmus
2018-06-07 7:47 ` Sahitihi
2018-06-07 8:25 ` Ricardo Wurmus
2018-06-08 17:01 ` Sahitihi
2018-06-09 0:57 ` Ricardo Wurmus
2018-06-09 18:08 ` Sahitihi
2018-06-09 20:57 ` Ricardo Wurmus
2018-06-11 12:14 ` Sahitihi
2018-06-11 12:28 ` Gábor Boskovits
2018-06-11 16:21 ` Sahitihi
2018-06-12 14:12 ` Ricardo Wurmus
2018-06-12 21:06 ` Sahitihi
2018-06-12 22:12 ` Ricardo Wurmus
2018-06-13 16:08 ` Sahithi Yarlagadda
2018-06-13 19:15 ` Ricardo Wurmus
2018-06-15 20:16 ` Sahitihi
2018-06-15 21:47 ` Next steps Ricardo Wurmus
2018-06-16 14:55 ` Sahitihi
2018-06-21 11:05 ` Ricardo Wurmus
2018-06-21 16:54 ` Sahithi Yarlagadda
2018-06-25 20:13 ` Sahithi Yarlagadda
2018-06-25 20:28 ` Ricardo Wurmus
2018-06-26 20:01 ` Gábor Boskovits
2018-06-29 22:51 ` Sahithi Yarlagadda
2018-07-03 2:29 ` Sahithi Yarlagadda
2018-06-24 18:25 ` Sahithi Yarlagadda
2018-06-24 20:22 ` Ricardo Wurmus
2018-06-24 20:33 ` Sahithi Yarlagadda
2018-06-11 12:37 ` Fwd: Re: Patch file for colorize module Ricardo Wurmus
2018-06-11 16:31 ` Sahitihi
2018-06-04 11:41 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7sdb5bk.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=sahi@swecha.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).