unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kkebreau@posteo.net>
To: swedebugia <swedebugia@riseup.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Octave & QtOctave
Date: Sun, 02 Dec 2018 20:07:49 -0500	[thread overview]
Message-ID: <87o9a3mn8a.fsf@posteo.net> (raw)
In-Reply-To: <324bf4a0-13f2-1579-5fa0-4a4e7937a6f9@riseup.net> (swedebugia's message of "Sun, 2 Dec 2018 22:18:47 +0100")

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

swedebugia <swedebugia@riseup.net> writes:

> On 2018-12-02 20:28, Kei Kebreau wrote:
> snip
>
>> Here are two tentative patches that make the changes we've discussed.
>
> Nice
>
>> Also, should we make a deprecated-package definition for qtoctave?
>
> Yes, that sounds like a good idea to me.

Here's the new second patch, then.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Rename-qtoctave-to-octave.patch --]
[-- Type: text/x-patch, Size: 1204 bytes --]

From 663441af034b6bd7a3bd24866d3721cac21be221 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@posteo.net>
Date: Sat, 1 Dec 2018 23:37:50 -0500
Subject: [PATCH 2/2] gnu: Rename "qtoctave" to "octave".

* gnu/packages/maths.scm (qtoctave): Define in terms of 'deprectated-package'.
(octave): New variable, formerly known as "qtoctave".
---
 gnu/packages/maths.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index bcd70232f..67be8b807 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1497,9 +1497,9 @@ Work may be performed both at the interactive command-line as well as via
 script files.")
     (license license:gpl3+)))
 
-(define-public qtoctave
+(define-public octave
   (package (inherit octave-cli)
-    (name "qtoctave")
+    (name "octave")
     (source (origin
               (inherit (package-source octave-cli))))
     (inputs
@@ -1525,6 +1525,9 @@ script files.")
                   "qscintilla2_qt5"))
                #t))))))))
 
+(define-public qtoctave
+  (deprecated-package "qtoctave" octave))
+
 (define-public opencascade-oce
   (package
     (name "opencascade-oce")
-- 
2.19.2


  reply	other threads:[~2018-12-03  1:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  0:56 Octave & QtOctave Brett Gilio
2018-11-24 13:12 ` Alex Vong
2018-11-24 22:10   ` ng0
2018-11-25 14:12     ` Should we rename qtoctave to octave and octave to octave-cli? (was Re: Octave & QtOctave) Alex Vong
2018-11-25 15:49       ` Brett Gilio
2018-11-25 15:58     ` Octave & QtOctave Ludovic Courtès
2018-11-27 17:53       ` Kei Kebreau
2018-11-28 10:47         ` Ludovic Courtès
2018-11-29 16:21           ` swedebugia
2018-12-02 19:25             ` Kei Kebreau
2018-12-02 19:28           ` Kei Kebreau
2018-12-02 21:18             ` swedebugia
2018-12-03  1:07               ` Kei Kebreau [this message]
2018-12-04 14:17             ` Alex Vong
2018-12-04 20:53               ` Kei Kebreau
2018-12-06  5:30                 ` Alex Vong
2018-12-06 15:42                   ` Kei Kebreau
2018-12-06 17:50                     ` Alex Vong
2018-12-07 15:52                       ` Kei Kebreau
2018-12-08 18:23                         ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9a3mn8a.fsf@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=guix-devel@gnu.org \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).