From: Christopher Baines <mail@cbaines.net>
To: guix-devel@gnu.org
Subject: Process for reviewing patches as someone without commit access
Date: Wed, 06 Sep 2023 16:55:12 +0100 [thread overview]
Message-ID: <87o7ifb66o.fsf@cbaines.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]
Hey!
I've been reviewing the list of ideas on and around QA ([1]) recently,
and got thinking again about how to support people without commit access
reviewing patches. Obviously you don't need commit access to review
patches, but where I think we need some process is how to expedite
someone with commit access taking a look at the patches that have been
reviewed, and merging them if appropriate.
1: https://qa.guix.gnu.org/README
Maybe we can use debbugs tags for this? It looks like this has already
been done in the past, I found some issues tagged with the usertag
"reviewed" for example [1]. Some were also tagged with
"reviewed-looks-good". I guess my primary concern is to have a tag (or
combination of tags) which indicate that a committer should have a look
at the issue as it's been reviewed by someone and should be ready to
merge. I don't really use debbugs much, but does anyone have any
opinions on appropriate tags?
1: https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=reviewed&users=guix
Once we know what tags to use, I can have the QA frontpage do something
similar to the "Mark as moreinfo" links, so it's easy to just click a
button then send the email to change the state of a issue.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next reply other threads:[~2023-09-06 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 15:55 Christopher Baines [this message]
2023-09-06 18:17 ` Process for reviewing patches as someone without commit access Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-06 18:19 ` Christopher Baines
2023-09-06 19:01 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-06 23:37 ` Simon Tournier
2023-09-06 23:59 ` Simon Tournier
2023-09-07 2:47 ` Maxim Cournoyer
2023-09-07 9:55 ` Simon Tournier
2023-09-07 16:19 ` Vagrant Cascadian
2023-09-07 19:05 ` Simon Tournier
2023-09-27 11:58 ` Christopher Baines
2023-10-04 15:46 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ifb66o.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).