unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	Simon Tournier <zimon.toutoune@gmail.com>
Cc: Christopher Baines <mail@cbaines.net>, guix-devel@gnu.org
Subject: Re: Process for reviewing patches as someone without commit access
Date: Thu, 07 Sep 2023 09:19:22 -0700	[thread overview]
Message-ID: <87v8cmklbp.fsf@wireframe> (raw)
In-Reply-To: <87jzt2og1z.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2350 bytes --]

On 2023-09-06, Maxim Cournoyer wrote:
> Simon Tournier <zimon.toutoune@gmail.com> writes:
>> On Wed, 06 Sep 2023 at 16:55, Christopher Baines <mail@cbaines.net> wrote:
>>
>>> Once we know what tags to use, I can have the QA frontpage do something
>>> similar to the "Mark as moreinfo" links, so it's easy to just click a
>>> button then send the email to change the state of a issue.
>>
>> That’s cool!
>>
>> Well, using emacs-debbugs and then
>>
>>     C-u M-x debbugs-gnu-usertags guix-patches RET
>>
>> the list of usertags is:
>>
>>         guix-patches  for-core-updates
>>         guix-patches  reviewed-looks-good
>>
>> And if instead of guix-patches we consider guix then it reads,
>>
>>         guix  build-system
>>         guix  cross-compilation
>>         guix  for-core-updates
>>         guix  looks-good
>>         guix  patch
>>         guix  plz-work
>>         guix  powerpc64le-linux
>>         guix  ready-to-review
>>         guix  reproducibility
>>         guix  reviewed
>>         guix  reviewed-looks-good
>>         guix  test-tag
>>         guix  v1.3.0
>>
>> However, I do not know how to list all the bugs for the package
>> guix-patches that matches the usertag reviewed-looks-good.  Anyway!
>
> Clicking on an entry in the above list shows them; I'm sure we could
> define a procedure to directly show the bugs associated with a usertag,
> which would be useful.
>
>> I think that the usertag ’reviewed’ is a good idea.  That would be a
>> very good start.  Then if it helps, we could add other usertags as
>> reviewed-julia for patches that the Julia team can merge.
>
> +1 for the 'reviewed' usertag (using the 'guix' user).
>
>> Discussing about idea, would it be possible that the QA infrastructure
>> automatically send a message to Debbugs for tagging?  For example, the
>> usertag ’qa-ok’ or whatever other meaningful name. :-)
>
> +1 for that as well, maybe 'qa-passed'.

Overall, I like this!

The only concern is that it is maintaining QA information in multiple
places, the QA service itself, and trying to mirror it to the bug
tracker...

QA might fail with a later patch iterations, so it should also then go
and remove the qa-passed tag? Should it remove the tag when QA is
currently in an unknown state?

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  parent reply	other threads:[~2023-09-07 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 15:55 Process for reviewing patches as someone without commit access Christopher Baines
2023-09-06 18:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-06 18:19   ` Christopher Baines
2023-09-06 19:01     ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-06 23:37       ` Simon Tournier
2023-09-06 23:59 ` Simon Tournier
2023-09-07  2:47   ` Maxim Cournoyer
2023-09-07  9:55     ` Simon Tournier
2023-09-07 16:19     ` Vagrant Cascadian [this message]
2023-09-07 19:05       ` Simon Tournier
2023-09-27 11:58 ` Christopher Baines
2023-10-04 15:46   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8cmklbp.fsf@wireframe \
    --to=vagrant@debian.org \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    --cc=maxim.cournoyer@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).