From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YIr4AyOt+GSn3QAA9RJhRA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 18:47:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YIr4AyOt+GSn3QAA9RJhRA (envelope-from ) for ; Wed, 06 Sep 2023 18:47:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2FE641BFD for ; Wed, 6 Sep 2023 18:47:30 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694018851; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=80g/eziwxVRMl2/X7gyhsOfq0rY5dOsxYnDqYxkjf58=; b=LUf7TQGZyHHndSDdF4sWqWN57mfa10LlidsxmkYbNPXf1ZxD100W1qZgB+DJ+GXlCsFYPs ltrinyKja8l+vX1v1R+sLbHxlD10pfZPDtRqOT4VsG4YfHj3VOO+P8datKVKd45ie7U+j5 0FD87sKAN/K73fkTp1LlaSm5rXW1Q99xXcEUZUQMw6X0UL4TMJJgG77SgHzx/YZ90ee6ju IYglZSFcsv70bAcPujGjbFYYghjqkf1eu7Mr/rzQ07GaFL/2hUgghMi9rAXe+KBuuGZhP8 +SSipGEiqg4OGG8a6Ql8bX3ONj9RxFg5dOsqz0fopoD2X6KmasiVDfT/MEUVWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694018851; a=rsa-sha256; cv=none; b=Ppn55btuyUmYTNhAWatuCd44mrukHqESueqF0SpDR7/XXA3rZfvKxk4N4gBjlj++KKBpTq koPJCdBSfn+/aE8wJBnxNMMYDm/AvvuANU23YgvfCEZo8nVdZshZIqrX6XIzJIWdZ9Td4e CcMgtoswbGlo5+DNQ1uP70cU5cslCgb0nsa916ZygaV+1A2vO3ASeIgrUWSYobZXWZltUs rihKjIkSFqp6bVw1BDaECDBafuia4MD+cXYGnhKVAXqs83WzfpMqKctV5ikSIYMguj+y25 mQUqO53LwVBOox1ie+7AmkZwOQPh/owy2/MoN0gRX8zE1h5O5McIPy8XBrCA/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdvg2-0002GZ-Ib; Wed, 06 Sep 2023 12:46:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdvg1-0002FM-04 for guix-devel@gnu.org; Wed, 06 Sep 2023 12:46:49 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdvfy-0005yL-Du for guix-devel@gnu.org; Wed, 06 Sep 2023 12:46:48 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id 63C9D27BBE2 for ; Wed, 6 Sep 2023 17:46:43 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 654cc7c9 for ; Wed, 6 Sep 2023 16:46:42 +0000 (UTC) User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines To: guix-devel@gnu.org Subject: Process for reviewing patches as someone without commit access Date: Wed, 06 Sep 2023 16:55:12 +0100 Message-ID: <87o7ifb66o.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.90 X-Spam-Score: -5.90 X-Migadu-Queue-Id: C2FE641BFD X-TUID: Xd1ug0t8jTbf --=-=-= Content-Type: text/plain Hey! I've been reviewing the list of ideas on and around QA ([1]) recently, and got thinking again about how to support people without commit access reviewing patches. Obviously you don't need commit access to review patches, but where I think we need some process is how to expedite someone with commit access taking a look at the patches that have been reviewed, and merging them if appropriate. 1: https://qa.guix.gnu.org/README Maybe we can use debbugs tags for this? It looks like this has already been done in the past, I found some issues tagged with the usertag "reviewed" for example [1]. Some were also tagged with "reviewed-looks-good". I guess my primary concern is to have a tag (or combination of tags) which indicate that a committer should have a look at the issue as it's been reviewed by someone and should be ready to merge. I don't really use debbugs much, but does anyone have any opinions on appropriate tags? 1: https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=reviewed&users=guix Once we know what tags to use, I can have the QA frontpage do something similar to the "Mark as moreinfo" links, so it's easy to just click a button then send the email to change the state of a issue. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmT4rO9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdUbA/+M35jmTnsTYxd9GssTYZg6WrlwI6ZoAFh OXYXdL6Nf+YS8fOE0akJqC8sHmt3vF7AlcdZaKM8NSexw2C37Nsov6pEN0sqnpyZ Z4f983sjg+FyEtxg4KkkuSxGvvcT9ReZH+RksY6S/rrpmXZy7znogxsXnLVzZL+k WoXCNVRkDchwGRi9hRVTGuupiL7deZoqIhNyi71ITkxvMsTcuQSM7Gkb1fN5sGm/ mJoHUWVqXsT4T87EN/X0QtzvckLQXMI0DUPt3XVF3755Y2RyCbOFVIR90DViFKqU Ftfgq9nTEnCMTdEQIKeE5PyqDDoRBbcMxDBqQhBtxCi7K8gYuTvDLTgaBqXzeDwf q8nsmBgeqHwm6TuDpsQ91u3P2S6B3Vyrv2qjaJFjdd7ZFqDhj6PPULN66ClZ639R V/NQJuHKZB4qXaDEiSebLsj8LFk6w7ZN3GxNDhKUXNll5GYiW848L8BQrJDuBE5m oUPj/5t0GWKr78k/u7sDPwIQd+ygKLNenhQCSwopb4+K6Tr/eBv2FPdFape7ILiF lovmggCGZXsdY8y4Cg0eY2DdIVVh0rXJvjT6xKUQzwjqn0oWqiLFbIrvGnKjbzee M6HOpNfc+b2nSZiH2s6hfgJR/bSJ7vjdzc9TuNkM58C8cvJ11KL1ujiWA/Z+OKFZ InNHbmP4haY= =tINO -----END PGP SIGNATURE----- --=-=-=--