unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Python: disable failing tests on MIPS64.
Date: Mon, 07 Apr 2014 20:10:33 -0400	[thread overview]
Message-ID: <87lhvgsmti.fsf@yeeloong.lan> (raw)
In-Reply-To: <1396908791-21832-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Tue, 8 Apr 2014 00:13:11 +0200")

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/patches/python-fix-tests.patch: disable two failing tests on
>   MIPS64.
> ---
>  gnu/packages/patches/python-fix-tests.patch | 38 +++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/patches/python-fix-tests.patch b/gnu/packages/patches/python-fix-tests.patch
> index eed4f36..70e4aa0 100644
> --- a/gnu/packages/patches/python-fix-tests.patch
> +++ b/gnu/packages/patches/python-fix-tests.patch
> @@ -74,3 +74,41 @@ http://bugs.python.org/issue20868 .
>       def test_wait_result(self):
>           if isinstance(self, ProcessesMixin) and sys.platform != 'win32':
>               pid = os.getpid()
> +--- Lib/ctypes/test/test_libc.py	2014-04-07 23:17:41.351235000 +0200
> ++++ Lib/ctypes/test/test_libc.py	2014-04-07 23:32:18.799235000 +0200
> +@@ -2,6 +2,7 @@
> + 
> + from ctypes import *
> + import _ctypes_test
> ++import platform
> + 
> + lib = CDLL(_ctypes_test.__file__)
> + 
> +@@ -17,6 +18,8 @@
> +         import math
> +         self.assertEqual(lib.my_sqrt(2.0), math.sqrt(2.0))
> + 
> ++    @unittest.skipIf(platform.machine() in ['mips64'],
> ++                     "This test fails on this platform")
> +     def test_qsort(self):
> +         comparefunc = CFUNCTYPE(c_int, POINTER(c_char), POINTER(c_char))
> +         lib.my_qsort.argtypes = c_void_p, c_size_t, c_size_t, comparefunc
> +--- Lib/ctypes/test/test_callbacks.py	2014-04-07 23:15:42.835235000 +0200
> ++++ Lib/ctypes/test/test_callbacks.py	2014-04-07 23:32:42.035235000 +0200
> +@@ -1,6 +1,7 @@
> + import unittest
> + from ctypes import *
> + import _ctypes_test
> ++import platform
> + 
> + class Callbacks(unittest.TestCase):
> +     functype = CFUNCTYPE
> +@@ -174,6 +175,8 @@
> + 
> +         self.assertLess(diff, 0.01, "%s not less than 0.01" % diff)
> + 
> ++    @unittest.skipIf(platform.machine() in ['mips64'],
> ++                     "This test fails on this platform")
> +     def test_issue_8959_a(self):
> +         from ctypes.util import find_library
> +         libc_path = find_library("c")

I've tested this on the Loongson 3A machine, and it works as expected.

    Thanks!
      Mark

  reply	other threads:[~2014-04-08  0:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 23:07 0.6 is around the corner! Ludovic Courtès
2014-04-01 18:50 ` Mark H Weaver
2014-04-01 19:20   ` Mark H Weaver
2014-04-01 20:02     ` Ludovic Courtès
2014-04-01 19:25   ` Ludovic Courtès
2014-04-02 19:43     ` Mark H Weaver
2014-04-03 16:32       ` Python 3 test failures Ludovic Courtès
2014-04-03 17:11         ` Mark H Weaver
2014-04-03 19:51           ` Ludovic Courtès
2014-04-06 19:41     ` 0.6 is around the corner! Ludovic Courtès
2014-04-06 21:33       ` [PATCH] gnu: Python: disable test_wait_result() as it fails on some setups Cyril Roelandt
2014-04-07  6:17         ` Mark H Weaver
2014-04-07 22:13           ` [PATCH] gnu: Python: disable failing tests on MIPS64 Cyril Roelandt
2014-04-08  0:10             ` Mark H Weaver [this message]
2014-04-08  3:50               ` Mark H Weaver
2014-04-09  0:40               ` Nikita Karetnikov
2014-04-09  2:51                 ` Cyril Roelandt
2014-04-09 16:04                   ` Nikita Karetnikov
2014-04-07  7:41         ` [PATCH] gnu: Python: disable test_wait_result() as it fails on some setups Ludovic Courtès
2014-04-07 21:45         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhvgsmti.fsf@yeeloong.lan \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).