From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: Python 3 test failures
Date: Thu, 03 Apr 2014 21:51:25 +0200 [thread overview]
Message-ID: <87ppkynqde.fsf@gnu.org> (raw)
In-Reply-To: <874n2aibik.fsf@yeeloong.lan> (Mark H. Weaver's message of "Thu, 03 Apr 2014 13:11:15 -0400")
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> ======================================================================
>>> ERROR: test_fork (test.test_pty.PtyTest)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>> File "/tmp/nix-build-python-3.3.3.drv-13/Python-3.3.3/Lib/test/test_pty.py", line 116, in test_fork
>>> pid, master_fd = pty.fork()
>>> File "/tmp/nix-build-python-3.3.3.drv-13/Python-3.3.3/Lib/pty.py", line 107, in fork
>>> master_fd, slave_fd = openpty()
>>> File "/tmp/nix-build-python-3.3.3.drv-13/Python-3.3.3/Lib/pty.py", line 29, in openpty
>>> master_fd, slave_name = _open_terminal()
>>> File "/tmp/nix-build-python-3.3.3.drv-13/Python-3.3.3/Lib/pty.py", line 70, in _open_terminal
>>> raise os.error('out of pty devices')
>>> OSError: out of pty devices
>>
>> This particular test is fixed by the daemon patch I posted, which makes
>> sure /dev/pts/ptmx is 0666 (I’ll update nix-upstream.)
>
> What are the security implications of this? Why do you suppose that
> Debian (or Linux, the kernel?) uses perms 0000 for /dev/pts/ptmx,
The devpts file system of Linux creates this file with perms 000 by
default:
https://www.kernel.org/doc/Documentation/filesystems/devpts.txt
> and how it is that these tests normally work outside of guix-daemon,
> when the perms are 0000?
Often, outside the chroot, /dev/ptmx is directly a character device,
with perms 0666. Conversely, inside the chroot it’s a symlink to
/dev/pts/ptmx (as suggested in devpts.txt), but until this patch was
applied, it had perms 000.
Ludo’.
next prev parent reply other threads:[~2014-04-03 19:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 23:07 0.6 is around the corner! Ludovic Courtès
2014-04-01 18:50 ` Mark H Weaver
2014-04-01 19:20 ` Mark H Weaver
2014-04-01 20:02 ` Ludovic Courtès
2014-04-01 19:25 ` Ludovic Courtès
2014-04-02 19:43 ` Mark H Weaver
2014-04-03 16:32 ` Python 3 test failures Ludovic Courtès
2014-04-03 17:11 ` Mark H Weaver
2014-04-03 19:51 ` Ludovic Courtès [this message]
2014-04-06 19:41 ` 0.6 is around the corner! Ludovic Courtès
2014-04-06 21:33 ` [PATCH] gnu: Python: disable test_wait_result() as it fails on some setups Cyril Roelandt
2014-04-07 6:17 ` Mark H Weaver
2014-04-07 22:13 ` [PATCH] gnu: Python: disable failing tests on MIPS64 Cyril Roelandt
2014-04-08 0:10 ` Mark H Weaver
2014-04-08 3:50 ` Mark H Weaver
2014-04-09 0:40 ` Nikita Karetnikov
2014-04-09 2:51 ` Cyril Roelandt
2014-04-09 16:04 ` Nikita Karetnikov
2014-04-07 7:41 ` [PATCH] gnu: Python: disable test_wait_result() as it fails on some setups Ludovic Courtès
2014-04-07 21:45 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppkynqde.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).