From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Python: disable failing tests on MIPS64. Date: Mon, 07 Apr 2014 20:10:33 -0400 Message-ID: <87lhvgsmti.fsf@yeeloong.lan> References: <87r459slxc.fsf@yeeloong.lan> <1396908791-21832-1-git-send-email-tipecaml@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXJdw-0006Rq-FL for guix-devel@gnu.org; Mon, 07 Apr 2014 20:12:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXJdr-0001Wf-64 for guix-devel@gnu.org; Mon, 07 Apr 2014 20:12:00 -0400 Received: from world.peace.net ([96.39.62.75]:47172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXJdq-0001WI-Tv for guix-devel@gnu.org; Mon, 07 Apr 2014 20:11:55 -0400 In-Reply-To: <1396908791-21832-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Tue, 8 Apr 2014 00:13:11 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel@gnu.org Cyril Roelandt writes: > * gnu/packages/patches/python-fix-tests.patch: disable two failing tests on > MIPS64. > --- > gnu/packages/patches/python-fix-tests.patch | 38 +++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/gnu/packages/patches/python-fix-tests.patch b/gnu/packages/patches/python-fix-tests.patch > index eed4f36..70e4aa0 100644 > --- a/gnu/packages/patches/python-fix-tests.patch > +++ b/gnu/packages/patches/python-fix-tests.patch > @@ -74,3 +74,41 @@ http://bugs.python.org/issue20868 . > def test_wait_result(self): > if isinstance(self, ProcessesMixin) and sys.platform != 'win32': > pid = os.getpid() > +--- Lib/ctypes/test/test_libc.py 2014-04-07 23:17:41.351235000 +0200 > ++++ Lib/ctypes/test/test_libc.py 2014-04-07 23:32:18.799235000 +0200 > +@@ -2,6 +2,7 @@ > + > + from ctypes import * > + import _ctypes_test > ++import platform > + > + lib = CDLL(_ctypes_test.__file__) > + > +@@ -17,6 +18,8 @@ > + import math > + self.assertEqual(lib.my_sqrt(2.0), math.sqrt(2.0)) > + > ++ @unittest.skipIf(platform.machine() in ['mips64'], > ++ "This test fails on this platform") > + def test_qsort(self): > + comparefunc = CFUNCTYPE(c_int, POINTER(c_char), POINTER(c_char)) > + lib.my_qsort.argtypes = c_void_p, c_size_t, c_size_t, comparefunc > +--- Lib/ctypes/test/test_callbacks.py 2014-04-07 23:15:42.835235000 +0200 > ++++ Lib/ctypes/test/test_callbacks.py 2014-04-07 23:32:42.035235000 +0200 > +@@ -1,6 +1,7 @@ > + import unittest > + from ctypes import * > + import _ctypes_test > ++import platform > + > + class Callbacks(unittest.TestCase): > + functype = CFUNCTYPE > +@@ -174,6 +175,8 @@ > + > + self.assertLess(diff, 0.01, "%s not less than 0.01" % diff) > + > ++ @unittest.skipIf(platform.machine() in ['mips64'], > ++ "This test fails on this platform") > + def test_issue_8959_a(self): > + from ctypes.util import find_library > + libc_path = find_library("c") I've tested this on the Loongson 3A machine, and it works as expected. Thanks! Mark