* Notes from the live patch review discussion today at the Guix Days
@ 2023-02-03 10:39 Christopher Baines
0 siblings, 0 replies; only message in thread
From: Christopher Baines @ 2023-02-03 10:39 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
These are some notes from the discuussion about patch review this
morning at the Guix Days.
Where to start:
- qa.guix.gnu.org
- debbugs.guix.gnu.org
- issues.guix.gnu.org
- debbugs.el
- email
- personal inbox
- lei (public inbox) ( https://yhetil.org/guix/ )
- IRC (someone asking for review)
Applying the patches locally:
- Pipe it from local email to git am
- lei emacs package, apply via public inbox and email id
- cherry pick commits from the branches that qa.guix.gnu.org creates
- (named issue-XXXXX)
What do people reviewing patches look at?
- What kind of patch, what is being changed?
- Testing the changes
- Look at the results of the qa.guix.gnu.org builds and linter
Once you've applied the patches:
- Email the bug/submitter
- Saving drafts as you review multiple patches can be helpful
- Do you remove guix-patches@gnu.org as a CC? Some do, some don't.
- Close via debbugs.el
- Showing the submitter what you've changed as a comitter
- Use the range diff in Git
- Copying the Git changes before fixing up/squashing
- Adding some Fixes: bit to the commit message, maybe we should do
this more?
Opportunities:
- Being able to see when the automated testing for an issue (all
issues) might finish
- ...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-03 10:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 10:39 Notes from the live patch review discussion today at the Guix Days Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).