From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YIk8EVvm3GONSQEAbAwnHQ (envelope-from ) for ; Fri, 03 Feb 2023 11:47:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QJcDEVvm3GOfEwAAauVa8A (envelope-from ) for ; Fri, 03 Feb 2023 11:47:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1EB0D32A1A for ; Fri, 3 Feb 2023 11:47:55 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNtbQ-0002F4-Rs; Fri, 03 Feb 2023 05:47:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNtbP-0002Ea-Hr for guix-devel@gnu.org; Fri, 03 Feb 2023 05:47:31 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNtbN-0002xG-RF for guix-devel@gnu.org; Fri, 03 Feb 2023 05:47:31 -0500 Received: from localhost (unknown [85.28.89.231]) by mira.cbaines.net (Postfix) with ESMTPSA id 8466627BBE9 for ; Fri, 3 Feb 2023 10:47:28 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a007f387 for ; Fri, 3 Feb 2023 10:47:27 +0000 (UTC) User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: guix-devel@gnu.org Subject: Notes from the live patch review discussion today at the Guix Days Date: Fri, 03 Feb 2023 11:39:23 +0100 Message-ID: <87lelff2ki.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675421275; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=re+H6o55tbxjnze4LEfV8C/RiLwLEvjesirjeAkR2DY=; b=EETZjVZLcu7EqahU3/OLTgOlkoKucHekdQCtd5xt6TNP9v1g3k/DQNgSKNNUsjOz20MxBc 7chfFP7eo1JlSWxzENAGMN+k69RiuJjDoz+yCx2ApNQN4CHt9fb7guG5Ec0W8+CX3kCMh1 DsG+jAMrOcaAXxXkiI2zbZF1Y0aQ2hvJgwJ6GY/LMHrmiQU6T8NoUR6ccQgciDUk8HEXiJ HQ2F3m/UnbKf8uGxt4C/BlWjp6ZskXP1gDsWLEPR7irsit5qaTLN1ytsicvB+DE13k820f Y6/RXuDwqztgnyTNQmvyK2tVp7pVd22inFAjLwJAvF4KwH4Ea4h/Ln66+CNr+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675421275; a=rsa-sha256; cv=none; b=RQmCPsgaCvh64CSyQ7wBQVCXfv7F9ocbzcMrAst49RpnMeqVted4kSlr01IVNcqaxXdiok pe0x287ZWruP9ess9TMQQg/qXBvTiUrp/+Tswhzrt828B6BBV+0Esin8Mikyfk7r6x+ajS vJ8cGUTCNWk38JdwMVbZKG9gE1V19rLArpPlpox5EBDjTrtZk4D8XiLPkisQbwXPzmYfEa +LcDNSQeFEv7HES9/c5XNd+Vjc1oibma+byTNMqpeyv3Bwd8GV5cIbR34xX0WgUJWEd+Mp I99D0YmpUcCxkiVPWRpEMKqZWq5i+ZZzU7QmHRIfkCXLXLeWW0yN1OxpG8udaw== X-Migadu-Queue-Id: 1EB0D32A1A X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.47 X-Spam-Score: -5.47 X-TUID: msUjtdhDV0sh --=-=-= Content-Type: text/plain These are some notes from the discuussion about patch review this morning at the Guix Days. Where to start: - qa.guix.gnu.org - debbugs.guix.gnu.org - issues.guix.gnu.org - debbugs.el - email - personal inbox - lei (public inbox) ( https://yhetil.org/guix/ ) - IRC (someone asking for review) Applying the patches locally: - Pipe it from local email to git am - lei emacs package, apply via public inbox and email id - cherry pick commits from the branches that qa.guix.gnu.org creates - (named issue-XXXXX) What do people reviewing patches look at? - What kind of patch, what is being changed? - Testing the changes - Look at the results of the qa.guix.gnu.org builds and linter Once you've applied the patches: - Email the bug/submitter - Saving drafts as you review multiple patches can be helpful - Do you remove guix-patches@gnu.org as a CC? Some do, some don't. - Close via debbugs.el - Showing the submitter what you've changed as a comitter - Use the range diff in Git - Copying the Git changes before fixing up/squashing - Adding some Fixes: bit to the commit message, maybe we should do this more? Opportunities: - Being able to see when the automated testing for an issue (all issues) might finish - ... --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPc5j1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeVCxAAjink1/MBXbuxTCLa7VVG6HfuV7KeAv8d 4R8GA+FeLFNkE9h5GBVR/N/7itZdiF1HdElPksSprB64Z1Hi8SH7lR5J0TcBtKgb Fj4Oh5BEjTYN4tI2RBpRXxfC78ycJ7l4nvzJP2+9ha+d4iK5mwXQ3gI/6i65D8bj RoU68Gr2UII2iVLKPTuyslnIR+Gdd6AlA94OdU6RDu0tqjB4mOQbRRxf1Rqee6xn WuJeJ7wZJ25cgW3QDQOU9DjswIvi8fgoVxrU+a4soKT9XVGSywMouayvYma1ynSw 5pufWvjwVRNlTpLQc99l8uwZenfuraEIxJevW0rrRZIvusm7Fxp+jmwZSWIBLLFE oPuxXIxnMze5B7ySyxd39A55gVSTZabN5g/WnN+HX5b1LbpFphirj+WtWZvK3eDw DUf9SvqxiOHRc40bxA+SKyEj++bxmGLTVXjegEjMUxn0GYo/gSeWMtaxwJAHSQA9 MlUZ/2Q/X4jMmTMT5Dsoav10P6CIRLXJhrs7WKqcZTVEh1ZETStobTKJ5RYIOWqu ZyE1f+uk7ya5sUebK0eq0GeMX8k+7dkdCrSvnp8Ujk9GjRuBPk7nZrOEyDajPse/ RDIbZsaEV633/KLTc+hI0xK/YBjhG3dyWe2T4RKMsGNuK4D3t0RAmX6WjuNUqr+k AGwxhEmErFY= =dBXI -----END PGP SIGNATURE----- --=-=-=--