From: ludo@gnu.org (Ludovic Courtès)
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] services: Add 'cuirass-service'.
Date: Thu, 27 Oct 2016 15:36:02 +0200 [thread overview]
Message-ID: <87k2ctkj7h.fsf@gnu.org> (raw)
In-Reply-To: <20161026130558.31924-3-mthl@gnu.org> (Mathieu Lirzin's message of "Wed, 26 Oct 2016 15:05:58 +0200")
Salut !
Mathieu Lirzin <mthl@gnu.org> skribis:
> * gnu/services/cuirass.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Continuous integration): New node.
[...]
> +++ b/doc/guix.texi
> @@ -7687,6 +7687,7 @@ declaration.
> * Mail Services:: IMAP, POP3, SMTP, and all that.
> * Web Services:: Web servers.
> * Network File System:: NFS related services.
> +* Continuous integration:: The cuirass service.
^ ^
Capitalize please. :-)
> +@deftp {Data Type} cuirass-configuration
> +Data type representing the configuration of Cuirass.
> +
> +@table @asis
> +@item @code{cache-directory} (default: "")
^^
Could you enclose it in @code? Same for the other default values.
> +@defvar %default-cuirass-configuration
So far we’ve used “@defvr {Scheme Variable} foo”, like Guile does. It
may be debatable, but I think we should be consistent.
I agree with Leo’s suggestion about the doc, but apart from that, it
looks all good. Nice work!
Thank you! I can’t wait to see it in action on the new machine. :-)
Ludo’.
next prev parent reply other threads:[~2016-10-27 13:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 13:05 [PATCH 0/2] Cuirass package + service Mathieu Lirzin
2016-10-26 13:05 ` [PATCH 1/2] gnu: Add Cuirass Mathieu Lirzin
2016-10-26 13:36 ` David Craven
2016-11-29 22:25 ` Mathieu Lirzin
2016-11-30 13:10 ` Ludovic Courtès
2016-10-26 13:05 ` [PATCH 2/2] services: Add 'cuirass-service' Mathieu Lirzin
2016-10-26 13:35 ` David Craven
2016-10-26 14:42 ` Mathieu Lirzin
2016-10-26 18:57 ` David Craven
2016-10-27 0:22 ` Leo Famulari
2016-11-06 13:16 ` Andreas Enge
2016-10-27 13:36 ` Ludovic Courtès [this message]
2016-11-29 22:22 ` Mathieu Lirzin
2016-11-30 21:53 ` Unable to configure a system with 'cuirass-service' ng0
2016-11-30 23:14 ` Carlo Zancanaro
2016-12-01 12:41 ` ng0
2016-12-01 12:59 ` Carlo Zancanaro
2016-12-01 13:23 ` ng0
2016-12-01 15:13 ` Carlo Zancanaro
2016-12-01 20:22 ` Mathieu Lirzin
2016-12-15 21:58 ` Mathieu Lirzin
2016-12-15 22:55 ` ng0
2016-12-15 23:15 ` Mathieu Lirzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ctkj7h.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mthl@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).