From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] services: Add 'cuirass-service'.
Date: Thu, 27 Oct 2016 15:36:02 +0200
Message-ID: <87k2ctkj7h.fsf@gnu.org>
References: <20161026130558.31924-1-mthl@gnu.org>
	<20161026130558.31924-3-mthl@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bzkqs-0005DH-K2
	for guix-devel@gnu.org; Thu, 27 Oct 2016 09:36:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bzkqo-0000zn-JI
	for guix-devel@gnu.org; Thu, 27 Oct 2016 09:36:14 -0400
In-Reply-To: <20161026130558.31924-3-mthl@gnu.org> (Mathieu Lirzin's message
	of "Wed, 26 Oct 2016 15:05:58 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Salut !

Mathieu Lirzin <mthl@gnu.org> skribis:

> * gnu/services/cuirass.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Continuous integration): New node.

[...]

> +++ b/doc/guix.texi
> @@ -7687,6 +7687,7 @@ declaration.
>  * Mail Services::               IMAP, POP3, SMTP, and all that.
>  * Web Services::                Web servers.
>  * Network File System::         NFS related services.
> +* Continuous integration::      The cuirass service.
                ^                      ^
Capitalize please.  :-)

> +@deftp {Data Type} cuirass-configuration
> +Data type representing the configuration of Cuirass.
> +
> +@table @asis
> +@item @code{cache-directory} (default: "")
                                          ^^
Could you enclose it in @code?  Same for the other default values.

> +@defvar %default-cuirass-configuration

So far we=E2=80=99ve used =E2=80=9C@defvr {Scheme Variable} foo=E2=80=9D, l=
ike Guile does.  It
may be debatable, but I think we should be consistent.

I agree with Leo=E2=80=99s suggestion about the doc, but apart from that, it
looks all good.  Nice work!

Thank you!  I can=E2=80=99t wait to see it in action on the new machine.  :=
-)

Ludo=E2=80=99.