unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] services: Add 'cuirass-service'.
Date: Wed, 26 Oct 2016 16:42:21 +0200	[thread overview]
Message-ID: <87insfmasy.fsf@gnu.org> (raw)
In-Reply-To: <CAL1_im=0K4QFLPzdkBZvbu5cqeP6JQCTfZ3_LNiUZTnYA3Myhg@mail.gmail.com> (David Craven's message of "Wed, 26 Oct 2016 15:35:56 +0200")

Hello David,

David Craven <david@craven.ch> writes:

> Do we need to export all of these?
>
> +            cuirass-configuration-cache-directory
> +            cuirass-configuration-group
> +            cuirass-configuration-interval
> +            cuirass-configuration-database
> +            cuirass-configuration-specifications
> +            cuirass-configuration-use-substitutes?
> +            cuirass-configuration-one-shot?
> +            %default-cuirass-configuration

Since the <cuirass-configuration> data type is documented in the manual,
the idea was to export the procedures that allow manipulating this type
in a REPL.  However since it appears that other services are not doing
that, I think it is better to remove them.

> Is %default-cuirass-configuration needed?

The benefit is a slightly more meaningful default value for #:CONFIG in
the 'cuirass-service' procedure documentation.  However I am not sure if
that helps much.  WDYT?

Thanks for the review.

-- 
Mathieu Lirzin

  reply	other threads:[~2016-10-26 14:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 13:05 [PATCH 0/2] Cuirass package + service Mathieu Lirzin
2016-10-26 13:05 ` [PATCH 1/2] gnu: Add Cuirass Mathieu Lirzin
2016-10-26 13:36   ` David Craven
2016-11-29 22:25     ` Mathieu Lirzin
2016-11-30 13:10       ` Ludovic Courtès
2016-10-26 13:05 ` [PATCH 2/2] services: Add 'cuirass-service' Mathieu Lirzin
2016-10-26 13:35   ` David Craven
2016-10-26 14:42     ` Mathieu Lirzin [this message]
2016-10-26 18:57       ` David Craven
2016-10-27  0:22   ` Leo Famulari
2016-11-06 13:16     ` Andreas Enge
2016-10-27 13:36   ` Ludovic Courtès
2016-11-29 22:22     ` Mathieu Lirzin
2016-11-30 21:53       ` Unable to configure a system with 'cuirass-service' ng0
2016-11-30 23:14         ` Carlo Zancanaro
2016-12-01 12:41           ` ng0
2016-12-01 12:59             ` Carlo Zancanaro
2016-12-01 13:23               ` ng0
2016-12-01 15:13                 ` Carlo Zancanaro
2016-12-01 20:22                   ` Mathieu Lirzin
2016-12-15 21:58                     ` Mathieu Lirzin
2016-12-15 22:55                       ` ng0
2016-12-15 23:15                         ` Mathieu Lirzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87insfmasy.fsf@gnu.org \
    --to=mthl@gnu.org \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).