From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system.
Date: Wed, 30 Nov 2016 13:51:23 +0100 [thread overview]
Message-ID: <87k2blku5w.fsf@gnu.org> (raw)
In-Reply-To: <1480444419-32288-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Tue, 29 Nov 2016 19:33:39 +0100")
John Darrington <jmd@gnu.org> skribis:
> * gnu/services/base.scm (file-system-shepherd-service): Use mount-file-system
> instead of manually mounting the file system.
[...]
> + #$(if create?
> + #~(mkdir-p #$target)
> + #~#t)
#~#t is equivalent to #t.
> + (mount-file-system
> + `(#$device #$title #$target #$type #$flags #$options
> + #$check?) #:root "/")
> #t))
#t must be align with the parent of “(mount-file-system”.
If you confirmed that at least “make check-system TESTS=basic” passes,
fine with me.
Thank you!
Ludo’.
next prev parent reply other threads:[~2016-11-30 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:33 [PATCH] gnu: file-system-shepherd-service: Use mount-file-system John Darrington
2016-11-30 12:51 ` Ludovic Courtès [this message]
2016-12-02 11:32 ` John Darrington
2016-12-02 16:44 ` David Craven
2016-12-04 21:12 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2blku5w.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).