unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Darrington <john@darrington.wattle.id.au>
To: Ludovic Court??s <ludo@gnu.org>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system.
Date: Fri, 2 Dec 2016 12:32:56 +0100	[thread overview]
Message-ID: <20161202113256.GA30350@jocasta.intra> (raw)
In-Reply-To: <87k2blku5w.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

On Wed, Nov 30, 2016 at 01:51:23PM +0100, Ludovic Court??s wrote:
     John Darrington <jmd@gnu.org> skribis:
     
     > * gnu/services/base.scm (file-system-shepherd-service): Use mount-file-system
     > instead of manually mounting the file system.
     
     [...]
     
     > +		       #$(if create?
     > +			     #~(mkdir-p #$target)
     > +			     #~#t)
     
     #~#t is equivalent to #t.
     
     > +		       (mount-file-system
     > +			`(#$device #$title #$target #$type #$flags #$options
     > +				   #$check?) #:root "/")
     >                         #t))
     
     #t must be align with the parent of ???(mount-file-system???.
     
     If you confirmed that at least ???make check-system TESTS=basic??? passes,
     fine with me.
     

Perhaps somebody who already has a copy of qemu in their store could check that
for me?

Currently I cannot run any system tests because of bug #25036

J'



-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2016-12-02 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 18:33 [PATCH] gnu: file-system-shepherd-service: Use mount-file-system John Darrington
2016-11-30 12:51 ` Ludovic Courtès
2016-12-02 11:32   ` John Darrington [this message]
2016-12-02 16:44     ` David Craven
2016-12-04 21:12     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202113256.GA30350@jocasta.intra \
    --to=john@darrington.wattle.id.au \
    --cc=guix-devel@gnu.org \
    --cc=jmd@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).