From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system.
Date: Wed, 30 Nov 2016 13:51:23 +0100
Message-ID: <87k2blku5w.fsf@gnu.org>
References: <1480444419-32288-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cC4ME-0005sy-Fp
	for guix-devel@gnu.org; Wed, 30 Nov 2016 07:51:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cC4MA-0002ji-EN
	for guix-devel@gnu.org; Wed, 30 Nov 2016 07:51:30 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53611)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1cC4MA-0002jX-Ad
	for guix-devel@gnu.org; Wed, 30 Nov 2016 07:51:26 -0500
In-Reply-To: <1480444419-32288-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Tue, 29 Nov 2016 19:33:39 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/services/base.scm (file-system-shepherd-service): Use mount-file-sy=
stem
> instead of manually mounting the file system.

[...]

> +		       #$(if create?
> +			     #~(mkdir-p #$target)
> +			     #~#t)

#~#t is equivalent to #t.

> +		       (mount-file-system
> +			`(#$device #$title #$target #$type #$flags #$options
> +				   #$check?) #:root "/")
>                         #t))

#t must be align with the parent of =E2=80=9C(mount-file-system=E2=80=9D.

If you confirmed that at least =E2=80=9Cmake check-system TESTS=3Dbasic=E2=
=80=9D passes,
fine with me.

Thank you!

Ludo=E2=80=99.