From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] import: pypi: Detect inputs. Date: Sun, 21 Jun 2015 22:56:03 +0200 Message-ID: <87ioagpyqk.fsf@gnu.org> References: <87d217uvzd.fsf@gnu.org> <1434331554-13170-1-git-send-email-tipecaml@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6mHk-0007ie-Aw for guix-devel@gnu.org; Sun, 21 Jun 2015 16:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6mHj-0007sf-FP for guix-devel@gnu.org; Sun, 21 Jun 2015 16:56:12 -0400 In-Reply-To: (Amirouche Boubekki's message of "Thu, 18 Jun 2015 12:45:41 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Amirouche Boubekki Cc: guix-devel@gnu.org, guix-devel-bounces+amirouche=hypermove.net@gnu.org Amirouche Boubekki skribis: > If I'm not mistaken this patch relies only on the presence of > requirements.txt. This is not a required file in python > packaging. otherwise said, we miss a lot using this method. I think > the best way to do that would be to: > > - download the package and extract it > - create an environment (#) > - create a virtual env with access to system site package of the > environment (#) > - enter the venv and install the package > - use `pip freeze -l` to retrieve the full set of dependencies Cyril, WDYT? I=E2=80=99m not familiar with the details, but my feeling is that reading requirements.txt is more lightweight, simpler, and more robust than what you propose. So I=E2=80=99d be inclined to apply Cyril=E2=80=99s patch ASAP. Thanks, Ludo=E2=80=99.