From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: [PATCH 2/2] services: Add 'cuirass-service'. Date: Wed, 26 Oct 2016 16:42:21 +0200 Message-ID: <87insfmasy.fsf@gnu.org> References: <20161026130558.31924-1-mthl@gnu.org> <20161026130558.31924-3-mthl@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzPPR-00055r-Cb for guix-devel@gnu.org; Wed, 26 Oct 2016 10:42:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzPPM-00018i-8D for guix-devel@gnu.org; Wed, 26 Oct 2016 10:42:29 -0400 In-Reply-To: (David Craven's message of "Wed, 26 Oct 2016 15:35:56 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel Hello David, David Craven writes: > Do we need to export all of these? > > + cuirass-configuration-cache-directory > + cuirass-configuration-group > + cuirass-configuration-interval > + cuirass-configuration-database > + cuirass-configuration-specifications > + cuirass-configuration-use-substitutes? > + cuirass-configuration-one-shot? > + %default-cuirass-configuration Since the data type is documented in the manual, the idea was to export the procedures that allow manipulating this type in a REPL. However since it appears that other services are not doing that, I think it is better to remove them. > Is %default-cuirass-configuration needed? The benefit is a slightly more meaningful default value for #:CONFIG in the 'cuirass-service' procedure documentation. However I am not sure if that helps much. WDYT? Thanks for the review. -- Mathieu Lirzin