* etc/commiter.scm should not commit
@ 2023-01-24 2:50 Csepp
2023-01-24 13:55 ` Ekaitz Zarraga
2023-01-25 9:33 ` Ricardo Wurmus
0 siblings, 2 replies; 4+ messages in thread
From: Csepp @ 2023-01-24 2:50 UTC (permalink / raw)
To: Guix Devel
There have been countless times when I was using etc/commiter.scm and it
commited more than it should have and then slapped an incorrect message
on it.
I think it would make a lot more sense if adding changes was left up to
the human at the keyboard (at least by default) and the script was
invoked only when editing the commit message.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: etc/commiter.scm should not commit
2023-01-24 2:50 etc/commiter.scm should not commit Csepp
@ 2023-01-24 13:55 ` Ekaitz Zarraga
2023-01-24 15:42 ` Csepp
2023-01-25 9:33 ` Ricardo Wurmus
1 sibling, 1 reply; 4+ messages in thread
From: Ekaitz Zarraga @ 2023-01-24 13:55 UTC (permalink / raw)
To: Csepp; +Cc: Guix Devel
------- Original Message -------
On Tuesday, January 24th, 2023 at 2:50 AM, Csepp <raingloom@riseup.net> wrote:
> There have been countless times when I was using etc/commiter.scm and it
> commited more than it should have and then slapped an incorrect message
> on it.
> I think it would make a lot more sense if adding changes was left up to
> the human at the keyboard (at least by default) and the script was
> invoked only when editing the commit message.
That could be done on a git hook but developers would need to configure it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: etc/commiter.scm should not commit
2023-01-24 13:55 ` Ekaitz Zarraga
@ 2023-01-24 15:42 ` Csepp
0 siblings, 0 replies; 4+ messages in thread
From: Csepp @ 2023-01-24 15:42 UTC (permalink / raw)
To: Ekaitz Zarraga; +Cc: Csepp, Guix Devel
Ekaitz Zarraga <ekaitz@elenq.tech> writes:
> ------- Original Message -------
> On Tuesday, January 24th, 2023 at 2:50 AM, Csepp <raingloom@riseup.net> wrote:
>
>
>> There have been countless times when I was using etc/commiter.scm and it
>> commited more than it should have and then slapped an incorrect message
>> on it.
>> I think it would make a lot more sense if adding changes was left up to
>> the human at the keyboard (at least by default) and the script was
>> invoked only when editing the commit message.
>
> That could be done on a git hook but developers would need to configure it.
It does not need to be a hook, it can be done by setting EDITOR or
VISUAL, or commiter.scm can even retain its current interface and just
internally git add everything and call the script that would decide the
message based on the staged diff.
^ permalink raw reply [flat|nested] 4+ messages in thread
* etc/commiter.scm should not commit
2023-01-24 2:50 etc/commiter.scm should not commit Csepp
2023-01-24 13:55 ` Ekaitz Zarraga
@ 2023-01-25 9:33 ` Ricardo Wurmus
1 sibling, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2023-01-25 9:33 UTC (permalink / raw)
To: Guix Devel; +Cc: Csepp
> There have been countless times when I was using etc/commiter.scm and it
> commited more than it should have and then slapped an incorrect message
> on it.
I wrote the initial version of etc/committer.scm to help me make 200+
commits for R updates. It performs that task as intended.
If it does not work correctly with arbitrarily complex changes I suggest
clearly specifying the expected behavior in a bug report.
--
Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-25 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-24 2:50 etc/commiter.scm should not commit Csepp
2023-01-24 13:55 ` Ekaitz Zarraga
2023-01-24 15:42 ` Csepp
2023-01-25 9:33 ` Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).