From: Csepp <raingloom@riseup.net>
To: Ekaitz Zarraga <ekaitz@elenq.tech>
Cc: Csepp <raingloom@riseup.net>, Guix Devel <guix-devel@gnu.org>
Subject: Re: etc/commiter.scm should not commit
Date: Tue, 24 Jan 2023 16:42:35 +0100 [thread overview]
Message-ID: <86pmb43pjr.fsf@riseup.net> (raw)
In-Reply-To: <T9_woNlcnX0eeTYLuOvoCSkRcRXTpdAgoiiqJCySOIcQ7_T1qeNo__j2J37vndcMkz4oosxCgkRmTbr4FiPTBnlwYmSi4jveGkzuRHRLd6s=@elenq.tech>
Ekaitz Zarraga <ekaitz@elenq.tech> writes:
> ------- Original Message -------
> On Tuesday, January 24th, 2023 at 2:50 AM, Csepp <raingloom@riseup.net> wrote:
>
>
>> There have been countless times when I was using etc/commiter.scm and it
>> commited more than it should have and then slapped an incorrect message
>> on it.
>> I think it would make a lot more sense if adding changes was left up to
>> the human at the keyboard (at least by default) and the script was
>> invoked only when editing the commit message.
>
> That could be done on a git hook but developers would need to configure it.
It does not need to be a hook, it can be done by setting EDITOR or
VISUAL, or commiter.scm can even retain its current interface and just
internally git add everything and call the script that would decide the
message based on the staged diff.
next prev parent reply other threads:[~2023-01-24 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 2:50 etc/commiter.scm should not commit Csepp
2023-01-24 13:55 ` Ekaitz Zarraga
2023-01-24 15:42 ` Csepp [this message]
2023-01-25 9:33 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pmb43pjr.fsf@riseup.net \
--to=raingloom@riseup.net \
--cc=ekaitz@elenq.tech \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).