Re: Python-build-system does not honour phases

[ludo@gnu.org (Ludovic Courtès)]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Andreas Enge <andreas@enge.fr> skribis:

> Apparently, the #:phases parameter has no influence on the python build
> system.
>
> For instance, when adding
> (arguments
>   `(#:phases '()))
> the package still gets built with the %standard-phases.
>
> I added a line
>    #:phases ,phases
> to
>    (define builder
> at line 131 of guix/build-system/python.scm.
>
> Now I can empty out the phases.

Yes, that’s the correct fix.

> But when I write something like
> #:phases
>   (alist-replace
>    'install
>    ...
>    %standard-phases)
> apparently the %standard-phases from the GNU build system are used,
> as there is an error message that ./configure is not found.
>
> Could maybe someone have a look and propose a solution?

The problem is that both the gnu-build-system and the
python-build-system were getting imported, and both export a
‘%standard-phases’.

The fix is to use only python-build-system:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 644 bytes --]

diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm
index b60adb1..ff34451 100644
--- a/guix/build-system/python.scm
+++ b/guix/build-system/python.scm
@@ -58,7 +58,6 @@
                                            (guix build gnu-build-system)
                                            (guix build utils)))
                        (modules '((guix build python-build-system)
-                                  (guix build gnu-build-system)
                                   (guix build utils))))
   "Build SOURCE using PYTHON, and with INPUTS.  This assumes that SOURCE
 provides a 'setup.py' file as its build system."

[-- Attachment #3: Type: text/plain, Size: 57 bytes --]


Could you check that and commit?

Thanks,
Ludo’.