From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Python-build-system does not honour phases Date: Mon, 09 Sep 2013 23:35:55 +0200 Message-ID: <87hadtfzk4.fsf@gnu.org> References: <20130907222607.GA28990@debian> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJ9Ci-000574-5l for guix-devel@gnu.org; Mon, 09 Sep 2013 17:41:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJ9Cb-0004nO-Oy for guix-devel@gnu.org; Mon, 09 Sep 2013 17:41:04 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:45539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJ9Cb-0004nJ-IY for guix-devel@gnu.org; Mon, 09 Sep 2013 17:40:57 -0400 In-Reply-To: <20130907222607.GA28990@debian> (Andreas Enge's message of "Sun, 8 Sep 2013 00:26:07 +0200") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andreas Enge skribis: > Apparently, the #:phases parameter has no influence on the python build > system. > > For instance, when adding > (arguments > `(#:phases '())) > the package still gets built with the %standard-phases. > > I added a line > #:phases ,phases > to > (define builder > at line 131 of guix/build-system/python.scm. > > Now I can empty out the phases. Yes, that=E2=80=99s the correct fix. > But when I write something like > #:phases > (alist-replace > 'install > ... > %standard-phases) > apparently the %standard-phases from the GNU build system are used, > as there is an error message that ./configure is not found. > > Could maybe someone have a look and propose a solution? The problem is that both the gnu-build-system and the python-build-system were getting imported, and both export a =E2=80=98%standard-phases=E2=80=99. The fix is to use only python-build-system: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm index b60adb1..ff34451 100644 --- a/guix/build-system/python.scm +++ b/guix/build-system/python.scm @@ -58,7 +58,6 @@ (guix build gnu-build-system) (guix build utils))) (modules '((guix build python-build-system) - (guix build gnu-build-system) (guix build utils)))) "Build SOURCE using PYTHON, and with INPUTS. This assumes that SOURCE provides a 'setup.py' file as its build system." --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Could you check that and commit? Thanks, Ludo=E2=80=99. --=-=-=--