From: ludo@gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>,
guix-devel <guix-devel@gnu.org>,
guix-blog@gnu.org
Subject: Re: Blog: Guix packaging tutorial
Date: Mon, 08 Oct 2018 14:20:13 +0200 [thread overview]
Message-ID: <87h8hw3a0y.fsf@gnu.org> (raw)
In-Reply-To: <874le2j3ox.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Wed, 03 Oct 2018 20:16:46 +0200")
Hello Pierre,
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
> Find the last revision attached. I've taken all comments into
> consideration and I'm quite happy with the result.
Neat! I like it too, I’d say we can go frmo here.
> I've found a much better advanced example: libgit2.
> The only thing is... it does not pass the tests.
Heh. :-)
> In guix, libgit2 uses an archive upstream. I've changed the package to
> check out the git repository. Only then the test fail:
>
> starting phase `check'
> Loaded 341 suites:
> Started
>
> apply::fromdiff...................
> apply::fromfile..........................................
> attr::file....
> attr::flags...
> attr::ignoreF
>
> 1) Failure:
> attr::ignore::honor_temporary_rules [/tmp/guix-build-my-libgit2-0.26.6-1.e98d0a3.drv-0/my-libgit2-0.26.6-1.e98d0a3-checkout/tests/clar_libgit2.c:47]
> Expression is not true: (fd = p_open(path, flags, mode)) >= 0
Could it be because the file it tries to open here is read-only?
Usually files resulting from a checkout are read-only, so perhaps you
need to make a bunch of files writable before the ‘check’ phase. For a
start you could do:
(for-each make-file-writable (find-files "tests"))
Once you’ve sorted that out I’m happy to publish if there are no
objections!
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-10-08 12:20 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 10:50 Blog: Guix packaging tutorial Pierre Neidhardt
2018-09-13 11:16 ` Pjotr Prins
2018-09-13 11:53 ` Ricardo Wurmus
2018-09-13 12:04 ` Pjotr Prins
2018-09-13 19:11 ` Andreas Enge
2018-09-14 11:07 ` Pierre Neidhardt
2018-09-14 11:33 ` Pjotr Prins
2018-09-24 17:00 ` Pierre Neidhardt
2018-09-24 17:37 ` Pierre Neidhardt
2018-09-27 13:43 ` Ludovic Courtès
2018-09-27 17:34 ` Pierre Neidhardt
2018-09-29 16:28 ` Ludovic Courtès
2018-09-29 21:18 ` Ricardo Wurmus
2018-09-30 19:01 ` Pierre Neidhardt
2018-09-30 19:44 ` Ludovic Courtès
2018-09-30 21:14 ` Pierre Neidhardt
2018-10-02 12:12 ` Ludovic Courtès
2018-10-02 16:02 ` Pierre Neidhardt
2018-10-02 19:46 ` Ricardo Wurmus
2018-10-03 8:10 ` Pierre Neidhardt
2018-10-03 18:16 ` Pierre Neidhardt
2018-10-08 12:20 ` Ludovic Courtès [this message]
2018-10-08 15:18 ` Ricardo Wurmus
2018-10-08 18:41 ` Pierre Neidhardt
2018-10-08 19:06 ` Pierre Neidhardt
2018-10-08 19:59 ` Ricardo Wurmus
2018-10-08 22:09 ` Pierre Neidhardt
2018-10-08 22:33 ` Pierre Neidhardt
2018-10-08 23:45 ` Pierre Neidhardt
2018-10-10 11:56 ` Ludovic Courtès
2018-10-10 13:20 ` George Clemmer
2018-10-10 13:31 ` Pierre Neidhardt
2018-10-10 14:13 ` Ricardo Wurmus
2018-10-10 14:00 ` Guix packaging tutorial is on-line! Ludovic Courtès
2018-10-10 14:12 ` Pierre Neidhardt
2018-10-10 15:07 ` Ricardo Wurmus
2018-10-10 16:09 ` Pierre Neidhardt
2018-10-11 13:41 ` Ludovic Courtès
2018-10-11 16:34 ` Pierre Neidhardt
2018-10-11 16:51 ` Pierre Neidhardt
2018-10-15 12:02 ` Ludovic Courtès
2018-10-15 12:39 ` Pierre Neidhardt
2018-10-20 19:58 ` Blog: Guix packaging tutorial Divan
2018-10-21 10:30 ` Pierre Neidhardt
2018-10-21 11:21 ` Pierre Neidhardt
2018-10-22 20:40 ` Divan Santana
2018-10-22 21:11 ` Pierre Neidhardt
2018-09-26 10:20 ` Ludovic Courtès
2018-09-26 10:28 ` Pierre Neidhardt
2018-09-27 11:56 ` Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2018-10-08 22:54 Benjamin Slade
2018-10-08 23:05 ` Pierre Neidhardt
2018-10-09 0:04 ` Benjamin Slade
2018-10-10 9:02 ` Ludovic Courtès
2018-10-11 1:38 ` Benjamin Slade
2018-10-11 9:37 ` Gábor Boskovits
2018-10-11 13:39 ` Ludovic Courtès
2018-10-12 1:05 ` Benjamin Slade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8hw3a0y.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-blog@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).