unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Benjamin Slade <slade@jnanam.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>, guix-blog@gnu.org
Subject: Re: Blog: Guix packaging tutorial
Date: Wed, 10 Oct 2018 19:38:08 -0600	[thread overview]
Message-ID: <87k1mp1cvz.fsf@jnanam.net> (raw)
In-Reply-To: <87va6a9nt9.fsf@gnu.org>

Hi Ludo',

So for me, the list at
<https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>
seems more like a list of `desired output conditions' and the numbering
doesn't really correspond directly to the temporal ordering of steps
(with some of the numbered items probably being temporally independent
but perhaps some not, which is somewhat confusing). For instance,
references to documentation (gender-neutral pronouns) occur lower in the
list than linting, and so if one tried to follow the checklist
temporally, one could end up doing things which invalidated the
linting. Should formatting occur before or after linting? Or is it
irrelevant?

For another instance, actually producing the patch (via `git
format-patch') is mentioned in the `preamble' but is not part of the
list (where reasonably it might occur near the end). And then there are
other things which are like steps (the actual sending of the patch)
which occur below the checklist.

It might make sense if there were:

A. a list of temporally-ordered steps for creating and submitting a package
 - where one of big steps could refer to Pierre's build tutorial
 - and where another step could refer to a list of things to check (B)

B. a non-temporal list of things to check before submitting
  (e.g. using gender-neutral pronouns in documentation isn't really a
  step, but a `desired output' condition)

 —Ben


On 2018-10-10T03:02:42-0600, Ludovic Courtès <ludo@gnu.org> wrote:

 > Hi Benjamin,

 > Benjamin Slade <slade@jnanam.net> skribis:

 > > ...But I was thinking about something a bit like Pjotr's list, though
 > > with a bit more detail. (E.g. things like using `git format-patch' to
 > > create patches for submission.)

 > Does the list at
 > <https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>
 > corresponds to what you’re looking for?

 > If not, we should probably change it (see doc/guix.texi in the repo.)

 > Thanks,
 > Ludo’.


--
Benjamin Slade - https://babbagefiles.xyz
  `(pgp_fp: ,(21BA 2AE1 28F6 DF36 110A 0E9C A320 BBE8 2B52 EE19))
    '(sent by mu4e on Emacs running under GNU/Linux . https://gnu.org )
       `(Choose Linux ,(Choose Freedom) . https://linux.com )

  reply	other threads:[~2018-10-11  1:38 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 22:54 Blog: Guix packaging tutorial Benjamin Slade
2018-10-08 23:05 ` Pierre Neidhardt
2018-10-09  0:04   ` Benjamin Slade
2018-10-10  9:02     ` Ludovic Courtès
2018-10-11  1:38       ` Benjamin Slade [this message]
2018-10-11  9:37         ` Gábor Boskovits
2018-10-11 13:39         ` Ludovic Courtès
2018-10-12  1:05           ` Benjamin Slade
  -- strict thread matches above, loose matches on Subject: below --
2018-09-13 10:50 Pierre Neidhardt
2018-09-13 11:16 ` Pjotr Prins
2018-09-13 11:53 ` Ricardo Wurmus
2018-09-13 12:04   ` Pjotr Prins
2018-09-13 19:11 ` Andreas Enge
2018-09-14 11:07   ` Pierre Neidhardt
2018-09-14 11:33     ` Pjotr Prins
2018-09-24 17:00       ` Pierre Neidhardt
2018-09-24 17:37         ` Pierre Neidhardt
2018-09-27 13:43           ` Ludovic Courtès
2018-09-27 17:34             ` Pierre Neidhardt
2018-09-29 16:28               ` Ludovic Courtès
2018-09-29 21:18           ` Ricardo Wurmus
2018-09-30 19:01             ` Pierre Neidhardt
2018-09-30 19:44               ` Ludovic Courtès
2018-09-30 21:14                 ` Pierre Neidhardt
2018-10-02 12:12                   ` Ludovic Courtès
2018-10-02 16:02                     ` Pierre Neidhardt
2018-10-02 19:46                       ` Ricardo Wurmus
2018-10-03  8:10                         ` Pierre Neidhardt
2018-10-03 18:16                           ` Pierre Neidhardt
2018-10-08 12:20                             ` Ludovic Courtès
2018-10-08 15:18                             ` Ricardo Wurmus
2018-10-08 18:41                               ` Pierre Neidhardt
2018-10-08 19:06                                 ` Pierre Neidhardt
2018-10-08 19:59                                 ` Ricardo Wurmus
2018-10-08 22:09                                   ` Pierre Neidhardt
2018-10-08 22:33                                     ` Pierre Neidhardt
2018-10-08 23:45                                       ` Pierre Neidhardt
2018-10-10 11:56                                         ` Ludovic Courtès
2018-10-10 13:20                                           ` George Clemmer
2018-10-10 13:31                                             ` Pierre Neidhardt
2018-10-10 14:13                                               ` Ricardo Wurmus
2018-10-20 19:58                                         ` Divan
2018-10-21 10:30                                           ` Pierre Neidhardt
2018-10-21 11:21                                             ` Pierre Neidhardt
2018-10-22 20:40                                               ` Divan Santana
2018-10-22 21:11                                                 ` Pierre Neidhardt
2018-09-26 10:20         ` Ludovic Courtès
2018-09-26 10:28           ` Pierre Neidhardt
2018-09-27 11:56             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1mp1cvz.fsf@jnanam.net \
    --to=slade@jnanam.net \
    --cc=guix-blog@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).