From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Blog: Guix packaging tutorial
Date: Mon, 08 Oct 2018 14:20:13 +0200
Message-ID: <87h8hw3a0y.fsf@gnu.org>
References: <87in397jsd.fsf@ambrevar.xyz> <20180913191151.GA1865@jurong>
	<87woro5ocf.fsf@ambrevar.xyz>
	<20180914113302.elqrk3tvdkln2cde@thebird.nl>
	<87o9cmj0fc.fsf@ambrevar.xyz> <87mus6iypf.fsf@ambrevar.xyz>
	<87zhw02ea9.fsf@mdc-berlin.de> <87o9cex112.fsf@ambrevar.xyz>
	<87efdau5x2.fsf@gnu.org> <87murywuvn.fsf@ambrevar.xyz>
	<87lg7go8cv.fsf@gnu.org> <87va6kuyk4.fsf@ambrevar.xyz>
	<87sh1ot9m5.fsf@elephly.net> <87bm8bv4ao.fsf@ambrevar.xyz>
	<874le2j3ox.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56198)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1g9UWn-00013D-FL
	for guix-devel@gnu.org; Mon, 08 Oct 2018 08:20:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1g9UWj-0007Jg-3s
	for guix-devel@gnu.org; Mon, 08 Oct 2018 08:20:49 -0400
In-Reply-To: <874le2j3ox.fsf@ambrevar.xyz> (Pierre Neidhardt's message of
	"Wed, 03 Oct 2018 20:16:46 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, guix-devel <guix-devel@gnu.org>, guix-blog@gnu.org

Hello Pierre,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Find the last revision attached.  I've taken all comments into
> consideration and I'm quite happy with the result.

Neat!  I like it too, I=E2=80=99d say we can go frmo here.

> I've found a much better advanced example: libgit2.
> The only thing is... it does not pass the tests.

Heh.  :-)

> In guix, libgit2 uses an archive upstream.  I've changed the package to
> check out the git repository.  Only then the test fail:
>
> starting phase `check'
> Loaded 341 suites:=20
> Started
>
> apply::fromdiff...................
> apply::fromfile..........................................
> attr::file....
> attr::flags...
> attr::ignoreF
>
>   1) Failure:
> attr::ignore::honor_temporary_rules [/tmp/guix-build-my-libgit2-0.26.6-1.=
e98d0a3.drv-0/my-libgit2-0.26.6-1.e98d0a3-checkout/tests/clar_libgit2.c:47]
>   Expression is not true: (fd =3D p_open(path, flags, mode)) >=3D 0

Could it be because the file it tries to open here is read-only?

Usually files resulting from a checkout are read-only, so perhaps you
need to make a bunch of files writable before the =E2=80=98check=E2=80=99 p=
hase.  For a
start you could do:

  (for-each make-file-writable (find-files "tests"))

Once you=E2=80=99ve sorted that out I=E2=80=99m happy to publish if there a=
re no
objections!

Thanks,
Ludo=E2=80=99.