From: Chris Marusich <cmmarusich@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org, 47615@debbugs.gnu.org
Subject: Re: bug#47615: [PATCH 2/9] gnu: guile-3.0: Fix building on powerpc-linux.
Date: Tue, 13 Apr 2021 21:00:43 -0700 [thread overview]
Message-ID: <87h7k91pn8.fsf_-_@gmail.com> (raw)
In-Reply-To: <c11ad7faa3690b2dfef924a31137f6ced5aab23f.1617711307.git.efraim@flashner.co.il> (Efraim Flashner's message of "Tue, 6 Apr 2021 15:32:46 +0300")
[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]
Efraim Flashner <efraim@flashner.co.il> writes:
> * gnu/packages/guile.scm (guile-3.0)[arguments]: On powerpc add two
> phases to adjust for 32-bit big-endian systems.
> ---
> gnu/packages/guile.scm | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
> index f63322794d..dca1b1c16f 100644
> --- a/gnu/packages/guile.scm
> +++ b/gnu/packages/guile.scm
> @@ -305,7 +305,26 @@ without requiring the source code to be rewritten.")
> (substitute-keyword-arguments (package-arguments guile-2.2)
> ((#:configure-flags flags ''())
> `(cons "--disable-jit" ,flags)))
> - (package-arguments guile-2.2)))
> + (if (string-prefix? "powerpc-" (%current-system))
> + (substitute-keyword-arguments (package-arguments guile-2.2)
> + ((#:phases phases)
> + `(modify-phases ,phases
> + (add-after 'unpack 'adjust-bootstrap-flags
> + (lambda _
> + ;; Upstream not yet notified about suggested solution.
> + ;; See existing bug reports:
> + ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45214
> + ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977223
> + (substitute* "bootstrap/Makefile.in"
> + (("^GUILE_OPTIMIZATIONS.*")
> + "GUILE_OPTIMIZATIONS = -O1 -Oresolve-primitives -Ocps\n"))
> + #t))
> + (add-after 'unpack 'remove-failing-tests
> + (lambda _
> + ;; TODO: Discover why this test fails on powerpc-linux
> + (delete-file "test-suite/standalone/test-out-of-memory")
> + #t)))))
> + (package-arguments guile-2.2))))
> (native-search-paths
> (list (search-path-specification
> (variable "GUILE_LOAD_PATH")
Generally this looks reasonable. I understand 3 weeks is a long
iteration time! I think it's OK to proceed if it works for
bootstrapping other software on this platform. Especially since the
change is isolated to just powerpc-linux.
Has the Guile test failure been reported upstream?
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-04-14 4:01 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 12:24 [bug#47615] [PATCH 0/9] Add 32-bit powerpc support Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 1/9] gnu: bootstrap: Add support for powerpc-linux Efraim Flashner
2021-04-14 3:51 ` bug#47615: " Chris Marusich
2021-04-14 7:36 ` Vincent Legoll
2021-04-14 13:56 ` [bug#47615] " Efraim Flashner
2021-05-05 1:52 ` bug#47615: " Chris Marusich
2021-05-05 8:51 ` Efraim Flashner
2021-05-06 16:35 ` Ludovic Courtès
2021-04-06 12:32 ` [bug#47615] [PATCH 2/9] gnu: guile-3.0: Fix building on powerpc-linux Efraim Flashner
2021-04-14 4:00 ` Chris Marusich [this message]
2021-04-14 14:00 ` bug#47615: " Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 3/9] gnu: binutils: Adjust test suite " Efraim Flashner
2021-04-17 19:51 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Chris Marusich
2021-04-17 20:02 ` bug#47615: [PATCH 3/9] gnu: binutils: Adjust test suite on powerpc-linux Chris Marusich
2021-04-18 9:23 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Efraim Flashner
2021-04-22 5:11 ` bug#47615: [PATCH 3/9] gnu: binutils: Adjust test suite on powerpc-linux Chris Marusich
2021-04-27 7:01 ` [bug#47615] " Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 4/9] gnu: mesa: Add support for powerpc-linux Efraim Flashner
2021-04-06 19:29 ` Efraim Flashner
2021-04-06 12:32 ` [PATCH 5/9] gnu: Add mac-fdisk Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 6/9] gnu: american-fuzzy-lop: Add support for powerpc-linux Efraim Flashner
2021-04-14 3:25 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Chris Marusich
2021-04-06 12:32 ` [bug#47615] [PATCH 7/9] build: qemu-command: Add support for powerpc Efraim Flashner
2021-04-06 17:02 ` Vincent Legoll
2021-04-06 19:17 ` Efraim Flashner
2021-04-06 22:27 ` Vincent Legoll
2021-04-06 12:32 ` [PATCH 8/9] gnu: mercurial: Skip tests on powerpc-linux Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 9/9] gnu: nss: " Efraim Flashner
2021-04-06 17:00 ` Vincent Legoll
2021-04-06 19:18 ` Efraim Flashner
2021-04-06 22:31 ` Vincent Legoll
2021-04-07 20:33 ` [PATCH 0/9] Add 32-bit powerpc support Vincent Legoll
2021-04-08 7:00 ` Efraim Flashner
2021-04-17 16:04 ` Ludovic Courtès
2021-04-17 16:51 ` Vincent Legoll
2021-04-17 19:42 ` Efraim Flashner
2021-04-17 20:07 ` Vincent Legoll
2021-05-06 14:38 ` bug#47615: " Ludovic Courtès
2021-05-10 8:20 ` Efraim Flashner
2021-05-11 20:24 ` Ludovic Courtès
2021-05-24 9:51 ` Efraim Flashner
2021-05-26 14:09 ` Ludovic Courtès
2021-05-31 10:23 ` Tobias Platen
2021-04-22 7:59 ` [bug#47615] [PATCH v2 00/12] " Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 01/12] gnu: bootstrap: Add support for powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 02/12] gnu: guile-3.0: Fix building on powerpc-linux Efraim Flashner
2021-05-06 14:45 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Ludovic Courtès
2021-05-10 8:01 ` Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 03/12] gnu: gcc-boot0: Use 128-bit long-double on powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 04/12] gnu: binutils: Fix bug in test suite in libiberty Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 05/12] gnu: mesa: Add support for powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 06/12] gnu: Add mac-fdisk Efraim Flashner
2021-05-06 14:48 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Ludovic Courtès
2021-05-06 15:48 ` [bug#47615] " Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 07/12] gnu: american-fuzzy-lop: Add support for powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 08/12] build: qemu-command: Add support for powerpc Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-linux Efraim Flashner
2021-04-22 16:41 ` [bug#47615] " Maxime Devos
2021-05-06 14:51 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Ludovic Courtès
2021-04-22 7:59 ` [PATCH v2 10/12] gnu: nss: Skip tests on powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 11/12] gnu: zstd: Adjust test suite for 32-bit architectures Efraim Flashner
2021-04-22 7:59 ` [bug#47615] [PATCH v2 12/12] gnu: glib: Disable failing test Efraim Flashner
2021-05-04 15:50 ` [PATCH v2 00/12] Add 32-bit powerpc support Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7k91pn8.fsf_-_@gmail.com \
--to=cmmarusich@gmail.com \
--cc=47615@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).