From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YDKxNB5pdmCPQwEAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 06:01:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UEt3Lh5pdmC2UwAAbx9fmQ (envelope-from ) for ; Wed, 14 Apr 2021 04:01:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A72D1F983 for ; Wed, 14 Apr 2021 06:01:34 +0200 (CEST) Received: from localhost ([::1]:42394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWWib-0003Ip-3k for larch@yhetil.org; Wed, 14 Apr 2021 00:01:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWWht-0003IU-Eu for guix-devel@gnu.org; Wed, 14 Apr 2021 00:00:49 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:41554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWWhr-0000KW-L4 for guix-devel@gnu.org; Wed, 14 Apr 2021 00:00:49 -0400 Received: by mail-pf1-x42a.google.com with SMTP id b28so1420474pft.8 for ; Tue, 13 Apr 2021 21:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=i2hG38kWsYZn9zPiToBIMW/zs7zLRwK+ds3YUEH4fRY=; b=uzpKpcGbP8oqnR5VcZ7k5CnIUtcooH1VKy1kshJNg6fMPDmqZlNmxwZEfWsHR0VnYz oJU7t05xUsPJBy53k/NxLb+GZ+KUEs/iUtl9u6xfbhhsX6dOrAfwjriihjLP5jB3S8dM EKQycpayFTEJwpwJ6GdbEw2Z+g1cY5fK79emb7xv3F1Wzw6pr5ifKa9vqw+J6fcZbmjY c+nOdUvDLl1u5g3bmWNuAyVnUHqAkNSir/D7qRK+sUIhZkn9jA6AVnEfCkKf3eXEq7Yr sXXyqy9/Ij9POOLOVlicc3MkcvYiKS0gB9oOUlMLv02Jo8gRY9b7VEBzCYwCmpxZUTdd Y1XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=i2hG38kWsYZn9zPiToBIMW/zs7zLRwK+ds3YUEH4fRY=; b=U8RL35O7hnShvoQ2AUEACHZZhqnKzJnuGHw8uanVpfHzyt6Lb+OqEaWSdR55jrceYy zR3hvowQd5jlf5MoPWveIUplvpXBVexWdd9NfcVa8H689/oj65iV7n0iqnYgjfW+i3Ji VL6ZxME9QjYLpDSzGCOpCnob5/WHaaAq8ebEl1bmTxivIW1H2k0DudAcJdjPfjGQ2q2F QQZ7CWMa+OE2vHvswLu+a+0dIoJb+xhi9kGGv2QcdVTLeUhf/t+wHjmr85VTF3ktEw8z Me1lNlXSA1zqSRPWWCSmexYSHbeMKvZv5HTaznnRs6dztOnJa8M1aAbwFWZ2+Eq8qi5O Sj1Q== X-Gm-Message-State: AOAM531JSooaLdSruZhsa7OgCeIGyO1ihpGznephs/loEmakXMxqdjgy DL4iNZhGMZ7EYU7KEDjf7yJehhYLMn9LQA== X-Google-Smtp-Source: ABdhPJyLeVxj/QJZ5x920DADCIntsp+DHay2BPVViJpACGtKLDTEm8bTGZoRbhCL/u1SNfVnqr8DKA== X-Received: by 2002:a65:5849:: with SMTP id s9mr36667802pgr.309.1618372845728; Tue, 13 Apr 2021 21:00:45 -0700 (PDT) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id q13sm13600599pfc.86.2021.04.13.21.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 21:00:44 -0700 (PDT) From: Chris Marusich To: Efraim Flashner Subject: Re: bug#47615: [PATCH 2/9] gnu: guile-3.0: Fix building on powerpc-linux. References: Date: Tue, 13 Apr 2021 21:00:43 -0700 In-Reply-To: (Efraim Flashner's message of "Tue, 6 Apr 2021 15:32:46 +0300") Message-ID: <87h7k91pn8.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=cmmarusich@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, 47615@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618372894; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=i2hG38kWsYZn9zPiToBIMW/zs7zLRwK+ds3YUEH4fRY=; b=e2VGJqPSMY+mOW9Iq0DqIrFauX50LajiZ+IPlpQpoe3PllCLKMZsH6yL94SueOp4oZwsBN r+i1lM0cdoi7XgWjplITi21BDPeEHPq0AA9bpcNEmvP+v+I5TO7jnQcLCnA6AGFQkol3da plOb0W5o4xdXwj/noM/EsdPd64ZnmXuxGIH0ANrU0HnvGfipdV36oiAU8KHkKFE+x0t0EO vO1Aseg8sHY80pCj3KUhUey8GRDuaLZSfsM/JQDuKvGBEBE3qo5H6pQ0O5DBkWnFXaw05k reS3lTUm4VewWQtoIQgc09Jk9iugzfi2nRXbmQiKFs2Je4spQCpp8f4bHKmhkw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618372894; a=rsa-sha256; cv=none; b=aDJIZ8daY/oTfqVgVhkYg1+C6ucKjPidLADFZt+6O4HP4g8JYr450DyulvNgmuAqRsN4uy E/R4fAO2BIWzOjAcjApUS86sLcJ6Uch7tVQ3v73thASLb33vEXK4h1vfzjOdjr28peiEj1 8vXidcUHkoiIH77BY2rM/WyOIUshnTCroJ6OIPLDsuwOaahE1r4fb5bh2N8yjNGCDJd3NV RvdrSdHcta2C7L5wMAgcIsj+7klISY0++siPOqov+YmC24P4lFaj7X0KOW0k7aUiKB8WcH 9oHlMX/RoEmC4p+RQpDT7UcEnwHZX4lyExm5R1BDwhzEJDQFczZgz1NQ43Oj3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=uzpKpcGb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=uzpKpcGb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 4A72D1F983 X-Spam-Score: -0.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: VgJL8E4Bw18+ --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > * gnu/packages/guile.scm (guile-3.0)[arguments]: On powerpc add two > phases to adjust for 32-bit big-endian systems. > --- > gnu/packages/guile.scm | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm > index f63322794d..dca1b1c16f 100644 > --- a/gnu/packages/guile.scm > +++ b/gnu/packages/guile.scm > @@ -305,7 +305,26 @@ without requiring the source code to be rewritten.") > (substitute-keyword-arguments (package-arguments guile-2.2) > ((#:configure-flags flags ''()) > `(cons "--disable-jit" ,flags))) > - (package-arguments guile-2.2))) > + (if (string-prefix? "powerpc-" (%current-system)) > + (substitute-keyword-arguments (package-arguments guile-2.2) > + ((#:phases phases) > + `(modify-phases ,phases > + (add-after 'unpack 'adjust-bootstrap-flags > + (lambda _ > + ;; Upstream not yet notified about suggested soluti= on. > + ;; See existing bug reports: > + ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D= 45214 > + ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bu= g=3D977223 > + (substitute* "bootstrap/Makefile.in" > + (("^GUILE_OPTIMIZATIONS.*") > + "GUILE_OPTIMIZATIONS =3D -O1 -Oresolve-primitive= s -Ocps\n")) > + #t)) > + (add-after 'unpack 'remove-failing-tests > + (lambda _ > + ;; TODO: Discover why this test fails on powerpc-li= nux > + (delete-file "test-suite/standalone/test-out-of-mem= ory") > + #t))))) > + (package-arguments guile-2.2)))) > (native-search-paths > (list (search-path-specification > (variable "GUILE_LOAD_PATH") Generally this looks reasonable. I understand 3 weeks is a long iteration time! I think it's OK to proceed if it works for bootstrapping other software on this platform. Especially since the change is isolated to just powerpc-linux. Has the Guile test failure been reported upstream? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmB2aOsVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadyJoP/1V+MT08z3SWPt06mleDHsQWRq/N JilsNkm32YfIVtHwiJ0SCwai9RqeErNf4wINfd4CxydxxEn1OBa5Wq9i/sd9vcdL dOE/k414UhxB8edKJVXH8pMsEyaXf/4D+tdWhdL/8As9x1Brr+FX/KH94oSE0cNh K5mnnu/eU/WIxIajqtsvGbuxLHx/ZsOzfTagb/8c/BUaL8CC8a8kp5Oh++eIioz6 +cU7Bp76rW2NH2TGdAhWuFvapMd1GApN7RJsFvPtKkF2gVvF1QeCJDYOxCZq9awG 3RCVGoGQoyZpJsLh2NruspO5NqoNIfLYGoh7FQraS/+/aoFoNkqW9BPNe8VgQI1h 28N3OrFZ0vxJ7pQGGQ5A5+ZzSxCY0E49s5JXARBWV7h55WvY8RyX+ASbKdHmnMzr FVdktwIYEjZUw2yr8djXm6s3vJMkognT+fshhofJfJiTVsZ6Vj9C3EocDtMXM/aE Ndwe9B/+imID0Vpa4glLzfLBzEQJ60z8CFI+0LMpMALT1rgb5/n9FUUC6zBnMi8+ 71A5X9F7y3uuDW48RRVyF9IgC5z0CQAwWsrbMJiQkw+Wm8Vn55Ufd7j5LnW8hxxs HbBYNmoMdk+e8+ZmAZtKZG8RNh+YKs9OWHBbi4aB8aMYgLk83II00fVD2usCukLt an2gChCUOFj/yPpk =qvAg -----END PGP SIGNATURE----- --=-=-=--