[ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch

[ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Hello,

As you may have noticed, there is a new "ungrafting" branch that intends
to remove most of the "grafts" people have to deal with on a regular
basis.

The CI (and undersigned) have gotten pretty far on building this branch,
but there is a problem: cURL lost its "curl-use-ssl-cert-env" patch in
commit cb8569e10c766f180c48c7cf74b74f7b4cb74541.

This patch adds support for the SSL_CERT_DIR and SSL_CERT_FILE variables
for any application using libcurl.

I only noticed this because I merged a new graft for cURL (1adeb74456,
a7737f0ead).

Now the question is: should we restore this patch, and in practice
restart the branch almost from scratch?  Or drop it, considering
upstream has rejected it[0]?

[0] https://github.com/curl/curl/pull/4809

As a middle ground, we can add it to the recent graft added in
1adeb74456, which won't require rebuilds.

Thoughts?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

Re: [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Marius Bakke <marius@gnu.org> skriver:

> Now the question is: should we restore this patch, and in practice
> restart the branch almost from scratch?  Or drop it, considering
> upstream has rejected it[0]?

Following a discussion on IRC, we decided to reinstate the patch and get
rid of the newly added graft at the same time.

Apologies to those who already started building it!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

Re: [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch

[Ludovic Courtès]

Hi!

Marius Bakke <marius@gnu.org> skribis:

> Marius Bakke <marius@gnu.org> skriver:
>
>> Now the question is: should we restore this patch, and in practice
>> restart the branch almost from scratch?  Or drop it, considering
>> upstream has rejected it[0]?
>
> Following a discussion on IRC, we decided to reinstate the patch and get
> rid of the newly added graft at the same time.
>
> Apologies to those who already started building it!

Thanks for the heads-up, and apologies for making this mistake in the
first place!

As we speak, substitute availability is at 34% on x86_64-linux…

Ludo’.