Re: [PATCH 2/2] dmd: Add dmd action 'reload': unload all; load.

[ludo@gnu.org (Ludovic Courtès)]

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> * modules/dmd/service.scm (runtime-load): New procedure.
>   (dmd-service): Re-factor 'load', add new action: 'reload'.
> * dmd.texi (The 'dmd' and 'unknown' services): Document 'reload'.
> * tests/basic.sh: Add 'reload' test.

Again I would call everything ‘reload’, for instance.  ‘runtime-load’
sounds like a pleonasm to me.

WDYT?

> --- a/tests/basic.sh
> +++ b/tests/basic.sh
> @@ -64,7 +64,8 @@ dmd_pid="`cat $pid`"
>  
>  kill -0 $dmd_pid
>  test -S "$socket"
> -$deco status dmd | grep -E '(Start.*dmd|Stop.*test)'
> +pristineStatus=$($deco status dmd) # Prep for 'reload' test.
> +echo $pristineStatus | grep -E '(Start.*dmd|Stop.*test)'

No camel case, please.  :-)

Also, use backquotes instead of $(...), which is Bash-specific.

>  $deco start test
>  test -f "$stamp"
> @@ -83,6 +84,9 @@ $deco unload dmd test
>  
>  $deco status dmd | grep "Stopped: (test-2)"
>  
> +$deco reload dmd "$conf"
> +[ "$($deco status dmd)" == "$pristineStatus" ]

Rather ‘test’ instead of ‘[’.

Could you post an updated patch?

Thanks!

Ludo’.