unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
To: guix-devel@gnu.org
Subject: Re: dmd: Unload one or all services at runtime.
Date: Wed, 19 Mar 2014 15:25:28 +0100	[thread overview]
Message-ID: <1395239129-10136-1-git-send-email-alex.sassmannshausen@gmail.com> (raw)
In-Reply-To: <87eh27gvd1.fsf@gnu.org>

Hello,

Please find an updated second patch which should arrive shortly.

Ludovic Courtès writes:

> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:
>
>> * modules/dmd/service.scm (runtime-load): New procedure.
>>   (dmd-service): Re-factor 'load', add new action: 'reload'.
>> * dmd.texi (The 'dmd' and 'unknown' services): Document 'reload'.
>> * tests/basic.sh: Add 'reload' test.
>
> Again I would call everything ‘reload’, for instance.  ‘runtime-load’
> sounds like a pleonasm to me.
>
> WDYT?

The procedure in question is now actually used by the 'load' and
'reload' actions, so simply calling it 'reload' would not be correct.

I can see it being a pleonasm, so I've renamed the procedure
'load-config'. To be clear, the new action itself IS called 'reload'
(so you would use it by 'deco reload dmd $file_name').

I've implemented your other suggestions, the tests pass.

Let me know if you have any other comments.

Cheers,

Alex

  reply	other threads:[~2014-03-19 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25  8:22 dmd: Unload one or all services at runtime Alex Sassmannshausen
2014-02-27 21:50 ` Ludovic Courtès
2014-03-10 17:39   ` [PATCH 1/2] dmd: Add dmd action unload: unload known services Alex Sassmannshausen
2014-03-10 17:39     ` [PATCH 2/2] dmd: Add dmd action 'reload': unload all; load Alex Sassmannshausen
2014-03-12 17:49       ` Ludovic Courtès
2014-03-19 14:25         ` Alex Sassmannshausen [this message]
2014-03-19 14:25           ` [PATCH] " Alex Sassmannshausen
2014-03-25 20:33             ` Ludovic Courtès
2014-03-25 20:30           ` dmd: Unload one or all services at runtime Ludovic Courtès
2014-03-12 17:45     ` [PATCH 1/2] dmd: Add dmd action unload: unload known services Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395239129-10136-1-git-send-email-alex.sassmannshausen@gmail.com \
    --to=alex.sassmannshausen@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).