From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] dmd: Add dmd action 'reload': unload all; load.
Date: Wed, 12 Mar 2014 18:49:46 +0100
Message-ID: <87eh27gvd1.fsf@gnu.org>
References: <87a9dcrzsh.fsf@gnu.org>
	<1394473161-14356-1-git-send-email-alex.sassmannshausen@gmail.com>
	<1394473161-14356-2-git-send-email-alex.sassmannshausen@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WNnHx-0005Qi-1v
	for guix-devel@gnu.org; Wed, 12 Mar 2014 13:50:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WNnHn-0007oS-Vp
	for guix-devel@gnu.org; Wed, 12 Mar 2014 13:49:56 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:60437)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WNnHn-0007oI-Ox
	for guix-devel@gnu.org; Wed, 12 Mar 2014 13:49:47 -0400
In-Reply-To: <1394473161-14356-2-git-send-email-alex.sassmannshausen@gmail.com>
	(Alex Sassmannshausen's message of "Mon, 10 Mar 2014 18:39:21 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
Cc: guix-devel@gnu.org

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> * modules/dmd/service.scm (runtime-load): New procedure.
>   (dmd-service): Re-factor 'load', add new action: 'reload'.
> * dmd.texi (The 'dmd' and 'unknown' services): Document 'reload'.
> * tests/basic.sh: Add 'reload' test.

Again I would call everything =E2=80=98reload=E2=80=99, for instance.  =E2=
=80=98runtime-load=E2=80=99
sounds like a pleonasm to me.

WDYT?

> --- a/tests/basic.sh
> +++ b/tests/basic.sh
> @@ -64,7 +64,8 @@ dmd_pid=3D"`cat $pid`"
>=20=20
>  kill -0 $dmd_pid
>  test -S "$socket"
> -$deco status dmd | grep -E '(Start.*dmd|Stop.*test)'
> +pristineStatus=3D$($deco status dmd) # Prep for 'reload' test.
> +echo $pristineStatus | grep -E '(Start.*dmd|Stop.*test)'

No camel case, please.  :-)

Also, use backquotes instead of $(...), which is Bash-specific.

>  $deco start test
>  test -f "$stamp"
> @@ -83,6 +84,9 @@ $deco unload dmd test
>=20=20
>  $deco status dmd | grep "Stopped: (test-2)"
>=20=20
> +$deco reload dmd "$conf"
> +[ "$($deco status dmd)" =3D=3D "$pristineStatus" ]

Rather =E2=80=98test=E2=80=99 instead of =E2=80=98[=E2=80=99.

Could you post an updated patch?

Thanks!

Ludo=E2=80=99.