Re: 08/10: gnu: readline: support mingw.

Re: 08/10: gnu: readline: support mingw.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit ae12d586275cdd96db23fb01bf840b2055b5b979
> Author: Jan Nieuwenhuizen <janneke@gnu.org>
> Date:   Tue Apr 12 15:49:17 2016 +0200
>
>     gnu: readline: support mingw.
>     
>     * gnu/packages/patches/readline-7.0-mingw.patch: New file.
>     * gnu-system.am (dist_patch_DATA): Add it.
>     * gnu/packages/readline.scm (readline): Support MinGW.
> ---
>  gnu/local.mk                                  |    1 +
>  gnu/packages/patches/readline-7.0-mingw.patch |   28 +++++++++++++++++++++++++
>  gnu/packages/readline.scm                     |   14 ++++++++++++-
>  3 files changed, 42 insertions(+), 1 deletion(-)

Hello!

This commit added a patch for readline, but it wasn't added to the
source.  Do you know if it is still required?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 08/10: gnu: readline: support mingw.

[Jan Nieuwenhuizen]

Marius Bakke writes:

Hi!

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit ae12d586275cdd96db23fb01bf840b2055b5b979
>> Author: Jan Nieuwenhuizen <janneke@gnu.org>
>> Date:   Tue Apr 12 15:49:17 2016 +0200
>>
>>     gnu: readline: support mingw.
>>     
>>     * gnu/packages/patches/readline-7.0-mingw.patch: New file.
>>     * gnu-system.am (dist_patch_DATA): Add it.
>>     * gnu/packages/readline.scm (readline): Support MinGW.
>> ---
>>  gnu/local.mk                                  |    1 +
>>  gnu/packages/patches/readline-7.0-mingw.patch |   28 +++++++++++++++++++++++++
>>  gnu/packages/readline.scm                     |   14 ++++++++++++-
>>  3 files changed, 42 insertions(+), 1 deletion(-)
>
> This commit added a patch for readline, but it wasn't added to the
> source.  Do you know if it is still required?

If you look at the readline recipe, you see this

--8<---------------cut here---------------start------------->8---
                   ,@(if (target-mingw?)
                         ;; MinGW: termcap in ncurses
                         ;; some SIG_* #defined in _POSIX
                         '(#:make-flags '("TERMCAP_LIB=-lncurses"
                                          "CPPFLAGS=-D_POSIX -D'chown(f,o,g)=0'"))
                         '())
--8<---------------cut here---------------end--------------->8---

I would consider this pretty ugly.  I think we tried and decided to
temporarily (ahem) use this option because adding the patch would
trigger a world rebuild for all archs.  I think we meant to remove the
above code and insert the patch when merging core-updates or something?

janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com