From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: 08/10: gnu: readline: support mingw. Date: Sun, 03 Dec 2017 17:19:47 +0100 Message-ID: <87efobeqcc.fsf@gnu.org> References: <20161207092335.28251.62559@vcs.savannah.gnu.org> <20161207092337.2696A2201B4@vcs.savannah.gnu.org> <87indnztri.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLWzx-0003jo-7y for guix-devel@gnu.org; Sun, 03 Dec 2017 11:20:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLWzt-0003Vy-9p for guix-devel@gnu.org; Sun, 03 Dec 2017 11:20:09 -0500 In-Reply-To: <87indnztri.fsf@fastmail.com> (Marius Bakke's message of "Sun, 03 Dec 2017 17:00:17 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke writes: Hi! > Ludovic Court=C3=A8s writes: > >> civodul pushed a commit to branch master >> in repository guix. >> >> commit ae12d586275cdd96db23fb01bf840b2055b5b979 >> Author: Jan Nieuwenhuizen >> Date: Tue Apr 12 15:49:17 2016 +0200 >> >> gnu: readline: support mingw. >>=20=20=20=20=20 >> * gnu/packages/patches/readline-7.0-mingw.patch: New file. >> * gnu-system.am (dist_patch_DATA): Add it. >> * gnu/packages/readline.scm (readline): Support MinGW. >> --- >> gnu/local.mk | 1 + >> gnu/packages/patches/readline-7.0-mingw.patch | 28 ++++++++++++++++++= +++++++ >> gnu/packages/readline.scm | 14 ++++++++++++- >> 3 files changed, 42 insertions(+), 1 deletion(-) > > This commit added a patch for readline, but it wasn't added to the > source. Do you know if it is still required? If you look at the readline recipe, you see this --8<---------------cut here---------------start------------->8--- ,@(if (target-mingw?) ;; MinGW: termcap in ncurses ;; some SIG_* #defined in _POSIX '(#:make-flags '("TERMCAP_LIB=3D-lncurses" "CPPFLAGS=3D-D_POSIX -D'chown(f,o= ,g)=3D0'")) '()) --8<---------------cut here---------------end--------------->8--- I would consider this pretty ugly. I think we tried and decided to temporarily (ahem) use this option because adding the patch would trigger a world rebuild for all archs. I think we meant to remove the above code and insert the patch when merging core-updates or something? janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com