From: Mark H Weaver <mhw@netris.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: cmake: Delete Emacs library.
Date: Tue, 22 May 2018 14:43:06 -0400 [thread overview]
Message-ID: <87d0xn7cqt.fsf@netris.org> (raw)
In-Reply-To: <20180522141741.641D120711@vcs0.savannah.gnu.org> (Oleg Pykhalov's message of "Tue, 22 May 2018 10:17:39 -0400 (EDT)")
Hi Oleg,
go.wigust@gmail.com (Oleg Pykhalov) writes:
> wigust pushed a commit to branch core-updates
> in repository guix.
>
> commit f037673c3133ae7453794f1f62eecebf9d06b092
> Author: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Tue May 22 07:41:45 2018 +0300
>
> gnu: cmake: Delete Emacs library.
>
> * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library.
According to "guix refresh -l cmake", this will require 2783 rebuilds on
x86_64, and probably similar numbers of rebuilds on other systems.
I think this is too much for core-updates right now, which has been
officially frozen since April 2.
Also, the commit log is wrong (it says that the changes were in
finance.scm), and:
> @@ -85,6 +85,12 @@
> " --exclude-regex ^\\(" (string-join skipped-tests "\\|") "\\)$")))
> #:phases
> (modify-phases %standard-phases
> + (add-after 'unpack 'split-package
> + ;; Remove files that have been packaged in other package recipes.
> + (lambda _
> + (delete-file "Auxiliary/cmake-mode.el")
> + (substitute* "Auxiliary/CMakeLists.txt"
> + ((".*cmake-mode.el.*") ""))))
this new phase that you've added returns an unspecified value, although
it is supposed to return a boolean to indicate success or failure.
Moreover, we're currently transitioning toward always returning #t from
phases and reporting any errors using exceptions instead.
In core-updates, we've made good progress toward this goal: all phases
for all core packages, and all packages that I build on my GNOME-based
GuixSD system, have been fixed to always return #t. It would be good to
avoid moving backwards w.r.t. to that goal.
So, I've reverted your commit on 'core-updates'. After fixing the
commit log and return value of the new phase, how about pushing this to
'core-updates-next' instead?
What do you think?
Mark
next parent reply other threads:[~2018-05-22 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180522141738.8231.26687@vcs0.savannah.gnu.org>
[not found] ` <20180522141741.641D120711@vcs0.savannah.gnu.org>
2018-05-22 18:43 ` Mark H Weaver [this message]
2018-05-23 16:10 ` 01/01: gnu: cmake: Delete Emacs library Oleg Pykhalov
2018-05-24 1:35 ` Mark H Weaver
2018-05-25 10:02 ` Oleg Pykhalov
2018-05-26 13:37 ` Marius Bakke
2018-05-28 9:41 ` Ludovic Courtès
2018-05-28 9:55 ` Vincent Legoll
2018-06-16 19:44 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0xn7cqt.fsf@netris.org \
--to=mhw@netris.org \
--cc=go.wigust@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).