From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/01: gnu: cmake: Delete Emacs library. Date: Tue, 22 May 2018 14:43:06 -0400 Message-ID: <87d0xn7cqt.fsf@netris.org> References: <20180522141738.8231.26687@vcs0.savannah.gnu.org> <20180522141741.641D120711@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLCGh-0000ew-0j for guix-devel@gnu.org; Tue, 22 May 2018 14:44:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLCGc-0006Z8-48 for guix-devel@gnu.org; Tue, 22 May 2018 14:44:19 -0400 Received: from world.peace.net ([64.112.178.59]:53336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fLCGb-0006Z2-Vx for guix-devel@gnu.org; Tue, 22 May 2018 14:44:14 -0400 In-Reply-To: <20180522141741.641D120711@vcs0.savannah.gnu.org> (Oleg Pykhalov's message of "Tue, 22 May 2018 10:17:39 -0400 (EDT)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Oleg Pykhalov Cc: guix-devel@gnu.org Hi Oleg, go.wigust@gmail.com (Oleg Pykhalov) writes: > wigust pushed a commit to branch core-updates > in repository guix. > > commit f037673c3133ae7453794f1f62eecebf9d06b092 > Author: Oleg Pykhalov > Date: Tue May 22 07:41:45 2018 +0300 > > gnu: cmake: Delete Emacs library. > > * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library. According to "guix refresh -l cmake", this will require 2783 rebuilds on x86_64, and probably similar numbers of rebuilds on other systems. I think this is too much for core-updates right now, which has been officially frozen since April 2. Also, the commit log is wrong (it says that the changes were in finance.scm), and: > @@ -85,6 +85,12 @@ > " --exclude-regex ^\\(" (string-join skipped-tests "\\|") "\\)$"))) > #:phases > (modify-phases %standard-phases > + (add-after 'unpack 'split-package > + ;; Remove files that have been packaged in other package recipes. > + (lambda _ > + (delete-file "Auxiliary/cmake-mode.el") > + (substitute* "Auxiliary/CMakeLists.txt" > + ((".*cmake-mode.el.*") "")))) this new phase that you've added returns an unspecified value, although it is supposed to return a boolean to indicate success or failure. Moreover, we're currently transitioning toward always returning #t from phases and reporting any errors using exceptions instead. In core-updates, we've made good progress toward this goal: all phases for all core packages, and all packages that I build on my GNOME-based GuixSD system, have been fixed to always return #t. It would be good to avoid moving backwards w.r.t. to that goal. So, I've reverted your commit on 'core-updates'. After fixing the commit log and return value of the new phase, how about pushing this to 'core-updates-next' instead? What do you think? Mark