From: Oleg Pykhalov <go.wigust@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: cmake: Delete Emacs library.
Date: Wed, 23 May 2018 19:10:49 +0300 [thread overview]
Message-ID: <87y3ga9wty.fsf@gmail.com> (raw)
In-Reply-To: <87d0xn7cqt.fsf@netris.org> (Mark H. Weaver's message of "Tue, 22 May 2018 14:43:06 -0400")
[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]
Hello Mark,
Mark H Weaver <mhw@netris.org> writes:
[…]
> go.wigust@gmail.com (Oleg Pykhalov) writes:
>
>> wigust pushed a commit to branch core-updates
>> in repository guix.
>>
>> commit f037673c3133ae7453794f1f62eecebf9d06b092
>> Author: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Tue May 22 07:41:45 2018 +0300
>>
>> gnu: cmake: Delete Emacs library.
>>
>> * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library.
[…]
> Also, the commit log is wrong (it says that the changes were in
> finance.scm), and:
Ouch, I'm sorry.
>> @@ -85,6 +85,12 @@
>> " --exclude-regex ^\\(" (string-join skipped-tests "\\|") "\\)$")))
>> #:phases
>> (modify-phases %standard-phases
>> + (add-after 'unpack 'split-package
>> + ;; Remove files that have been packaged in other package recipes.
>> + (lambda _
>> + (delete-file "Auxiliary/cmake-mode.el")
>> + (substitute* "Auxiliary/CMakeLists.txt"
>> + ((".*cmake-mode.el.*") ""))))
>
> this new phase that you've added returns an unspecified value, although
> it is supposed to return a boolean to indicate success or failure.
substitute* returns #t if it finds a file and error otherwise. Do I
miss understand something?
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (substitute* "/tmp/test.txt" (("Hello") "foo"))
$3 = #t
scheme@(guile-user)> (substitute* "/tmp/test.txt" (("bla") "foo"))
$4 = #t
scheme@(guile-user)> (substitute* "/tmp/test.txtf" (("bla") "foo"))
ERROR: In procedure stat:
In procedure stat: No such file or directory: "/tmp/test.txtf"
Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
--8<---------------cut here---------------end--------------->8---
/tmp/test.txt
--8<---------------cut here---------------start------------->8---
Hello
--8<---------------cut here---------------end--------------->8---
[…]
> After fixing the commit log and return value of the new phase, how
> about pushing this to 'core-updates-next' instead?
OK, I'll do it later.
> What do you think?
core-updates-next branch should be mentioned in Guix documentation
https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-05-23 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180522141738.8231.26687@vcs0.savannah.gnu.org>
[not found] ` <20180522141741.641D120711@vcs0.savannah.gnu.org>
2018-05-22 18:43 ` 01/01: gnu: cmake: Delete Emacs library Mark H Weaver
2018-05-23 16:10 ` Oleg Pykhalov [this message]
2018-05-24 1:35 ` Mark H Weaver
2018-05-25 10:02 ` Oleg Pykhalov
2018-05-26 13:37 ` Marius Bakke
2018-05-28 9:41 ` Ludovic Courtès
2018-05-28 9:55 ` Vincent Legoll
2018-06-16 19:44 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3ga9wty.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).