Re: Help, and get help reviewing patches this Friday (18th)

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]


Jack Hill <jackhill@jackhill.us> writes:

> On Thu, 17 Dec 2020, Christopher Baines wrote:
>
>> Hey,
>>
>> I mentioned in [1] that some "Scheduled and regular collaboration on IRC
>> to review patches" might help both get some patches reviewed, but help
>> get more people involved in reviewing patches, even if they haven't done
>> so before.
>>
>> 1: https://lists.gnu.org/archive/html/guix-devel/2020-11/msg00583.html
>>
>> The suggestion came to do this on a Friday, and I have some time
>> tomorrow (Friday the 18th) that I can set aside to be on IRC and try and
>> help.
>
> Thanks, this sounds like a great initiative, and I'll try to drop
> by. I'm in North America though, so I might be a little tardy (despite
> how much fun the 4am Guix Day was!).

Great, and there's no such thing as being late in this case, well, apart
from me sending the email, it was already tomorrow in some places!

> On the topic of patch review, I was recently asked how I reviewed a
> proposed Go upgrade. I responded on the bug tracker [0]. I'd be
> interested in hearing critiques on the method I used. It might be nice
> to collect some recipes for reviewing different kinds of changes in
> the cookbook :)
>
> [0] https://issues.guix.gnu.org/45161#11

Yeah, this is stuff it would be neat to share. On my side, I've been
working on tooling (Guix Data Service, Guix Build Coordinator) to do a
similar thing (build packages that are affected by patches, and compare
the builds to identify breakages).

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]