From: Jack Hill <jackhill@jackhill.us>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: Help, and get help reviewing patches this Friday (18th)
Date: Thu, 17 Dec 2020 11:02:09 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.2.21.2012171051460.5691@marsh.hcoop.net> (raw)
In-Reply-To: <87ft44323d.fsf@cbaines.net>
On Thu, 17 Dec 2020, Christopher Baines wrote:
> Hey,
>
> I mentioned in [1] that some "Scheduled and regular collaboration on IRC
> to review patches" might help both get some patches reviewed, but help
> get more people involved in reviewing patches, even if they haven't done
> so before.
>
> 1: https://lists.gnu.org/archive/html/guix-devel/2020-11/msg00583.html
>
> The suggestion came to do this on a Friday, and I have some time
> tomorrow (Friday the 18th) that I can set aside to be on IRC and try and
> help.
Thanks, this sounds like a great initiative, and I'll try to drop by. I'm
in North America though, so I might be a little tardy (despite how much
fun the 4am Guix Day was!).
On the topic of patch review, I was recently asked how I reviewed a
proposed Go upgrade. I responded on the bug tracker [0]. I'd be interested
in hearing critiques on the method I used. It might be nice to collect
some recipes for reviewing different kinds of changes in the cookbook :)
[0] https://issues.guix.gnu.org/45161#11
Best,
Jack
next prev parent reply other threads:[~2020-12-17 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 15:05 Help, and get help reviewing patches this Friday (18th) Christopher Baines
2020-12-17 16:02 ` Jack Hill [this message]
2020-12-17 18:19 ` Christopher Baines
2020-12-18 16:56 ` Ludovic Courtès
2020-12-18 21:09 ` zimoun
2020-12-20 10:25 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2012171051460.5691@marsh.hcoop.net \
--to=jackhill@jackhill.us \
--cc=guix-devel@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).