From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 77N3CXGh218jHAAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 18:20:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sNjHBHGh21+sHgAAB5/wlQ (envelope-from ) for ; Thu, 17 Dec 2020 18:20:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9DC6940363 for ; Thu, 17 Dec 2020 18:20:32 +0000 (UTC) Received: from localhost ([::1]:60232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpxt9-0002LJ-Ic for larch@yhetil.org; Thu, 17 Dec 2020 13:20:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpxsl-0002KS-8i for guix-devel@gnu.org; Thu, 17 Dec 2020 13:20:09 -0500 Received: from mira.cbaines.net ([212.71.252.8]:39486) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpxsd-0007C9-Tc for guix-devel@gnu.org; Thu, 17 Dec 2020 13:20:07 -0500 Received: from localhost (188.30.130.172.threembb.co.uk [188.30.130.172]) by mira.cbaines.net (Postfix) with ESMTPSA id 00F7327BC04; Thu, 17 Dec 2020 18:19:57 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 8504d966; Thu, 17 Dec 2020 18:19:55 +0000 (UTC) References: <87ft44323d.fsf@cbaines.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Jack Hill Subject: Re: Help, and get help reviewing patches this Friday (18th) In-reply-to: Date: Thu, 17 Dec 2020 18:19:53 +0000 Message-ID: <87czz82t2u.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: B9DC6940363 X-Spam-Score: -1.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: i9yYazPePpIG --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jack Hill writes: > On Thu, 17 Dec 2020, Christopher Baines wrote: > >> Hey, >> >> I mentioned in [1] that some "Scheduled and regular collaboration on IRC >> to review patches" might help both get some patches reviewed, but help >> get more people involved in reviewing patches, even if they haven't done >> so before. >> >> 1: https://lists.gnu.org/archive/html/guix-devel/2020-11/msg00583.html >> >> The suggestion came to do this on a Friday, and I have some time >> tomorrow (Friday the 18th) that I can set aside to be on IRC and try and >> help. > > Thanks, this sounds like a great initiative, and I'll try to drop > by. I'm in North America though, so I might be a little tardy (despite > how much fun the 4am Guix Day was!). Great, and there's no such thing as being late in this case, well, apart from me sending the email, it was already tomorrow in some places! > On the topic of patch review, I was recently asked how I reviewed a > proposed Go upgrade. I responded on the bug tracker [0]. I'd be > interested in hearing critiques on the method I used. It might be nice > to collect some recipes for reviewing different kinds of changes in > the cookbook :) > > [0] https://issues.guix.gnu.org/45161#11 Yeah, this is stuff it would be neat to share. On my side, I've been working on tooling (Guix Data Service, Guix Build Coordinator) to do a similar thing (build packages that are affected by patches, and compare the builds to identify breakages). Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/boUlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeXGA//WZ0yNg8u1BL1XZI+rnCxIhtAz0go9L4u GW65YKSJphh1YeJU90TAuWKhyCFkXNQ9SDpilvRIdW0LNwyLTDU/llhLy8lb+JwY jqvAte+tjgB/xEXZ2vFTT0PvuLnjlf/w2QnfZIWuFELvY/OC87bEg9S8C7F/h9Ga 9rf61qtd8x2lnSIjBROl1842TVtsUeHO6l5yDyJl3hHE8CxkrzVYxQGE58rXG67R vlQCEnHLmcyjsbfoaXokftzEhkPBi24Hhh8FHf09q7ipP7i5DJ4hFJ2Sw8Jo7whv H2jL8/nXBkHv3yagtPRBq2v8KIPHrpKi0zyNm8sE8v7StD4yGMjWIjPL9PpseHdV ZjiumGcV9YtJt3G8aqAmac0+WensZWeUbmxPqlqtD1nOAOHaUCyScujv40+/MBXu 3SaEwn+Dpy5e9AVRo6vLp893RF9mgSwRepZSYDDjNwNE4/ZPWPdUjd7av5nenKgo SmRaa3ijut0RkCFIF3yMp4E1pMjS5OReSZ8Ek4feR5MxPCaYTE+ngSxDoFWOdVBJ bJyXT6FXNYYXxOgnM7rxjhz5/zK77zxlU8Dx7KvE3hUSWXDAeZry5ZiC3sIct7p8 TKZziGNIcQKrfleu45PrJIbCyjivaczAGTUdYXWBIWqex3zFKLFrL2bqJ2SiKsVM 682bA76YMU0= =UK43 -----END PGP SIGNATURE----- --=-=-=--