unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Phil <phil@beadling.co.uk>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Types and builds for mypy
Date: Sat, 22 Oct 2022 18:05:48 +0100	[thread overview]
Message-ID: <87a65ndc0j.fsf@beadling.co.uk> (raw)
In-Reply-To: <87y1t8t16n.fsf@gmail.com>

Thanks for your reply Maxim,

Maxim Cournoyer writes:


> Is MyPy the only consumer of Python type annotations?  I think so, but
> I'm not sure.  If it's the only one, it'd make sense to move mypy and
> all the annotation types to (gnu packages python-types), I think.

Mypy is certainly a prominent consumer, but you're right - PEP 561 type stub
packages are also used by PyCharm, pytype, and I've heard CPython can
use them to compile, to name a few.

So I think my revised opinion is mypy should stay where it is, but I do
like the idea of keeping all the types in one module?

Co-locating them with the module they provide type for also works fine,
but I kinda see the type files as visual noise if we put them in
packages which are organized into categories they don't directly
contribute to. Perhaps they are better kept in once place?

It also means that when running mypy you can just import your
python-types module, and be sure it's going to work.


> I think if it doesn't negatively impact its use, we should go ahead and
> make this change in the mypy package.
>
> Happy to review patches!

Cool thanks - leave this with me, I have a working package so can submit
a patch shortly!


  reply	other threads:[~2022-10-24  2:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 10:09 Types and builds for mypy Philip Beadling
2022-10-22 13:53 ` Maxim Cournoyer
2022-10-22 17:05   ` Phil [this message]
2022-10-25 23:47     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a65ndc0j.fsf@beadling.co.uk \
    --to=phil@beadling.co.uk \
    --cc=guix-devel@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).