From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cCROBKf4VWNNOAAAbAwnHQ (envelope-from ) for ; Mon, 24 Oct 2022 04:29:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SDZaBKf4VWN75AAA9RJhRA (envelope-from ) for ; Mon, 24 Oct 2022 04:29:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB8D3179C3 for ; Mon, 24 Oct 2022 04:29:58 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omicE-0004BG-QF for larch@yhetil.org; Sun, 23 Oct 2022 17:34:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omHwZ-00086T-WC for guix-devel@gnu.org; Sat, 22 Oct 2022 13:05:56 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omHwX-0002oS-LJ for guix-devel@gnu.org; Sat, 22 Oct 2022 13:05:55 -0400 Received: by mail-wm1-x32d.google.com with SMTP id b20-20020a05600c4e1400b003cc28585e2fso711905wmq.1 for ; Sat, 22 Oct 2022 10:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beadling-co-uk.20210112.gappssmtp.com; s=20210112; h=mime-version:date:message-id:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=LIXmYHkNRFMKi63WkoeDCkHJz/9EqzkHqEqf4PYd4v8=; b=04EbHS0kaJ0Dm5oTUF0DqzLYOVTvgJpkOkq2AYGtUmMym7poXFuRO28zue10oF1f8n UwIAL/qjKQibOl4Grzj/HY6E4MaO56hEN2KYh8UtltmjX1q0IOnVDqw1t8h6bKYGgLUw hRg2Q9i+3iGBf1yG6zKRg+IjZ1/YS9NQrS5S6VMkfuH16M5swKxS3HcAAnOIjH5zVhAf s4Pcg6fOOsJZ4s+bVeJ+biFBwwl6MxsyZiUnamsfIwZO88KR23gI1UqZ5r8ZDLcC44Ay GycZG6cKT754vDvbPtMPRY3wY0fyAZxwXPf11vI6U1gT2srinc2+Li4wLM6yCKnCRwYF pmJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:date:message-id:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LIXmYHkNRFMKi63WkoeDCkHJz/9EqzkHqEqf4PYd4v8=; b=abytPbz/gC2ZykgZqY1pvdgg5jM4RTa06vBGa6HiCRPjUzEK6MTjeo12rXgna3InY7 aYKvi6VedMCinTFNhKfSxLOao6tNZhoCEw7EGFBd8rRKCEY/qdvgKn0GUQ/X46Xfo0kc yIYgJ0jez+7V2vSVeSNYNWxx7YsWuvWWkWTxtrPeIkp4cV99WrrM8nXL0fs6Sdzsb+nX xziLyEzy6X59xIP3HC1cyk+X09F+UD2MqFB4wOPZD1GIoRv0qtZSuuNuErghCJ4+4E4p +zbXgj4EGmY1wXYGZU05YRrsj7Uyu95xYj8Td6WaT+uj/P/v36dSkALpgDAUcwaoGQra jxGA== X-Gm-Message-State: ACrzQf0cK6EY5kFrct4imz1WSSF6X4/XWz041B00cyN2fFbZi9qgfXb1 xs3INUbIfHpX6RANqgPGtZem7MfrPlUnue7i X-Google-Smtp-Source: AMsMyM6KineanoGcsVzbhe+6Wrcdpru6/PS72BCfQX89MPhGNHurw8szxp4UwS00GFpWicr/4x6acQ== X-Received: by 2002:a05:600c:538a:b0:3c6:c223:7ec5 with SMTP id hg10-20020a05600c538a00b003c6c2237ec5mr17352288wmb.37.1666458349777; Sat, 22 Oct 2022 10:05:49 -0700 (PDT) Received: from xps13 ([2a02:6b61:74a5:0:3e3e:75ff:de88:7a90]) by smtp.gmail.com with ESMTPSA id n5-20020a5d67c5000000b0023662245d3csm1411389wrw.95.2022.10.22.10.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Oct 2022 10:05:49 -0700 (PDT) References: <87y1t8t16n.fsf@gmail.com> User-agent: mu4e 1.4.15; emacs 27.2 From: Phil To: Maxim Cournoyer Cc: "guix-devel@gnu.org" Subject: Re: Types and builds for mypy In-reply-to: <87y1t8t16n.fsf@gmail.com> Message-ID: <87a65ndc0j.fsf@beadling.co.uk> Date: Sat, 22 Oct 2022 18:05:48 +0100 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=2a00:1450:4864:20::32d; envelope-from=phil@beadling.co.uk; helo=mail-wm1-x32d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666578598; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LIXmYHkNRFMKi63WkoeDCkHJz/9EqzkHqEqf4PYd4v8=; b=ss7gg5A53JsiVKbfQQOQ4/GgnvQk5zFaThkopqvy7bvQ5qTo7RKcDEtIF/e7MEsZIr+e3M f09lvamnF03WrSlNHzmOAaNUoxssIkmdlgU3qGe9awBK2GFPOMGrepEttSmd3aXoa0Zce6 z2F7dDvUDGBmuec5m7urY4ZAOvcXmbFEUtuP34px4ORNDD/JFEBKHUVIbPiI2lZ6Q4uvQj PftcqoPW2Q4nC3TeDP522jeEXpjGh/ynzgj9EbqmB1rMPWrTThRRckCKNh7o4lCxlKmIF1 i0P9FTufJyNSbQGR7TYPt9CefcXknUz9ZiqgjeVFhVS0DbB/vIiQ0J3KNvHrzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666578598; a=rsa-sha256; cv=none; b=V9fEBljFMxw8CJz1MT6Jg77jX+9IL41KdkuGfGymcrLKuWtyd+qXCemvw8vGPm75x4bv+S mPy80MEzVv69cLbc80eusMrtcjP8IGSQRVJ4ZRzbHDA5uohIl4y/+azyjeg11EKKCsP3Ml xRc+0FbW9j3BiTsM9hFQKBABAgQm2dxNYVbHvqr2XKvSOhm8p8PErCRdzR8jfDI6JyRP2a ZV9hpziCmQILI29Szd9W1LG6FW01JtcFdal259+YP4fCop38Vh2tTuX3zGHUEzo5IDn//e 8+2WbdBhnhDiCZ6qJMBvh6+cb9b1mVtIz97/3jjrYoJCbILSjHS7BbWhzBATgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=beadling-co-uk.20210112.gappssmtp.com header.s=20210112 header.b=04EbHS0k; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.91 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=beadling-co-uk.20210112.gappssmtp.com header.s=20210112 header.b=04EbHS0k; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BB8D3179C3 X-Spam-Score: -0.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: vLKdfADotE+Z Thanks for your reply Maxim, Maxim Cournoyer writes: > Is MyPy the only consumer of Python type annotations? I think so, but > I'm not sure. If it's the only one, it'd make sense to move mypy and > all the annotation types to (gnu packages python-types), I think. Mypy is certainly a prominent consumer, but you're right - PEP 561 type stub packages are also used by PyCharm, pytype, and I've heard CPython can use them to compile, to name a few. So I think my revised opinion is mypy should stay where it is, but I do like the idea of keeping all the types in one module? Co-locating them with the module they provide type for also works fine, but I kinda see the type files as visual noise if we put them in packages which are organized into categories they don't directly contribute to. Perhaps they are better kept in once place? It also means that when running mypy you can just import your python-types module, and be sure it's going to work. > I think if it doesn't negatively impact its use, we should go ahead and > make this change in the mypy package. > > Happy to review patches! Cool thanks - leave this with me, I have a working package so can submit a patch shortly!