unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Philip Beadling <phil@beadling.co.uk>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Types and builds for mypy
Date: Sat, 22 Oct 2022 09:53:04 -0400	[thread overview]
Message-ID: <87y1t8t16n.fsf@gmail.com> (raw)
In-Reply-To: <LO0P123MB389821EC364A02B628ADDD21F9289@LO0P123MB3898.GBRP123.PROD.OUTLOOK.COM> (Philip Beadling's message of "Tue, 18 Oct 2022 10:09:46 +0000")

Hi,

Philip Beadling <phil@beadling.co.uk> writes:

> Hi all
>
> Users of mypy and python will have noticed since the promotion of mypy to v0. 971 it is now neccesary to provide separate python packages containing types of non core libraries.
>
> The way we've been collecting these, outside of Guix proper, is in a single module called python-types, which can then simply be added as a native-input to any python build requiring mypy.
>
> The alternative is to colocate the types with their packages, or perhaps colocate them all with mypy itself.

Is MyPy the only consumer of Python type annotations?  I think so, but
I'm not sure.  If it's the only one, it'd make sense to move mypy and
all the annotation types to (gnu packages python-types), I think.

> My preference is to put them all in one module, I think.
>
> Is there formal strategy in Guix for how to organise these packages?  I'd be happy to make available our current python-types.scm as a starting point?
>
> Finally and slightly related I note that by default the 971 package of
> mypy is not C compiled using mypyc.  It's a simple tweak to turn this
> on in the package and it makes huge performance difference when using
> mypy (on average 4x faster is quoted).  Again, happy to offer up a
> modified or inherited package if other people are frustrated by the
> slow down?

I think if it doesn't negatively impact its use, we should go ahead and
make this change in the mypy package.

Happy to review patches!

-- 
Thanks,
Maxim


  reply	other threads:[~2022-10-23 20:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 10:09 Types and builds for mypy Philip Beadling
2022-10-22 13:53 ` Maxim Cournoyer [this message]
2022-10-22 17:05   ` Phil
2022-10-25 23:47     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1t8t16n.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=phil@beadling.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).